deps: upgrade npm in LTS to 3.10.10 #9847

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@iarna
Contributor
iarna commented Nov 29, 2016
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

This release is really small, just a fix for a regression where failed optional dependencies in shrinkwraps could cause the entire install to fail. This also corrects the supported Node.js versions to include 0.12.

Changelogs

r: @jasnell
r: @Fishrock123

@Fishrock123
Member

I think this also needs to land on v7?

@Fishrock123
Member

LGTM even on v7

@MylesBorins
Member

I would say that until we have discussed v4 at the ctc meeting this should land on master and be backported to 7 / 6

thoughts?

@Fishrock123
Member

@TheAlphaNerd I agree. I'll handle it.

@Fishrock123 Fishrock123 removed the v6.x label Dec 5, 2016
@Fishrock123 Fishrock123 changed the base branch to nodejs:master from nodejs:v6.x-staging Dec 5, 2016
@Fishrock123 Fishrock123 changed the base branch to nodejs:v6.x-staging from nodejs:master Dec 5, 2016
@Fishrock123
Member

Landed in 95b238a on master, thanks!

@Fishrock123 Fishrock123 closed this Dec 5, 2016
@Fishrock123 Fishrock123 added a commit that referenced this pull request Dec 5, 2016
@iarna @Fishrock123 iarna + Fishrock123 deps: upgrade npm to 3.10.10
PR-URL: #9847
95b238a
@jasnell
Member
jasnell commented Dec 5, 2016

The commit appears to have landed without metadata and I'm curious about the base branch changes. This PR says it was intended for v6.x-staging but landed on master?

@Fishrock123
Member

force-pushed, landed in c8cf71d now.

@jasnell To answer your other question, this is effectively targeting the wrong branch.

@Fishrock123 Fishrock123 added a commit that referenced this pull request Dec 5, 2016
@iarna @Fishrock123 iarna + Fishrock123 deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
c8cf71d
@Fishrock123 Fishrock123 added a commit that referenced this pull request Dec 5, 2016
@iarna @Fishrock123 iarna + Fishrock123 deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
4bcda63
@Fishrock123 Fishrock123 referenced this pull request Dec 5, 2016
Merged

v7.2.1 proposal #10127

2 of 2 tasks complete
@jmdarling jmdarling added a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@iarna @jmdarling iarna + jmdarling deps: upgrade npm to 3.10.10
PR-URL: nodejs#9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
086389d
@MylesBorins MylesBorins added a commit that referenced this pull request Dec 13, 2016
@iarna @MylesBorins iarna + MylesBorins deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
284d3cc
@hulbert
hulbert commented Dec 15, 2016

Apologies if this is an inappropriate place to ask but any sense of when a 6.x.x release will go out with this? It is the single thing blocking us from switching to node 6.

Funnily enough we've had a branch w/ node 6 passing CI and then it broke as soon as we tried the 6.9.x LTS releases because of this.

@MylesBorins
Member

@hulbert this is is staging. Expect an RC next week and a release in 3

@MylesBorins MylesBorins added a commit that referenced this pull request Dec 21, 2016
@iarna @MylesBorins iarna + MylesBorins deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
3c5966f
@MylesBorins MylesBorins referenced this pull request Dec 21, 2016
Merged

V6.9.3 proposal #10394

@MylesBorins MylesBorins added a commit to MylesBorins/node that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2016-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) nodejs#9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             nodejs#9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            nodejs#10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) nodejs#9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) nodejs#8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    nodejs#8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) nodejs#10103
    - improved support for generator functions (Teddy Katz)
      nodejs#9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) nodejs#9685

PR-URL: nodejs#10394
93a9109
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394
42149d7
@MylesBorins MylesBorins added a commit that referenced this pull request Jan 3, 2017
@MylesBorins MylesBorins 2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394
2bf1c24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment