New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm in LTS to 3.10.10 #9847

Closed
wants to merge 1 commit into
base: v6.x-staging
from

Conversation

Projects
None yet
6 participants
@iarna
Member

iarna commented Nov 29, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

This release is really small, just a fix for a regression where failed optional dependencies in shrinkwraps could cause the entire install to fail. This also corrects the supported Node.js versions to include 0.12.

Changelogs

r: @jasnell
r: @Fishrock123

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Nov 30, 2016

Member

I think this also needs to land on v7?

Member

Fishrock123 commented Nov 30, 2016

I think this also needs to land on v7?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Nov 30, 2016

Member

LGTM even on v7

Member

Fishrock123 commented Nov 30, 2016

LGTM even on v7

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 1, 2016

Member

I would say that until we have discussed v4 at the ctc meeting this should land on master and be backported to 7 / 6

thoughts?

Member

MylesBorins commented Dec 1, 2016

I would say that until we have discussed v4 at the ctc meeting this should land on master and be backported to 7 / 6

thoughts?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Dec 5, 2016

Member

@thealphanerd I agree. I'll handle it.

Member

Fishrock123 commented Dec 5, 2016

@thealphanerd I agree. I'll handle it.

@Fishrock123 Fishrock123 removed the v6.x label Dec 5, 2016

@Fishrock123 Fishrock123 changed the base branch from v6.x-staging to master Dec 5, 2016

@Fishrock123 Fishrock123 changed the base branch from master to v6.x-staging Dec 5, 2016

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Dec 5, 2016

Member

Landed in 95b238a on master, thanks!

Member

Fishrock123 commented Dec 5, 2016

Landed in 95b238a on master, thanks!

@Fishrock123 Fishrock123 closed this Dec 5, 2016

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Dec 5, 2016

Member

The commit appears to have landed without metadata and I'm curious about the base branch changes. This PR says it was intended for v6.x-staging but landed on master?

Member

jasnell commented Dec 5, 2016

The commit appears to have landed without metadata and I'm curious about the base branch changes. This PR says it was intended for v6.x-staging but landed on master?

@Fishrock123

This comment has been minimized.

Show comment
Hide comment
@Fishrock123

Fishrock123 Dec 5, 2016

Member

force-pushed, landed in c8cf71d now.

@jasnell To answer your other question, this is effectively targeting the wrong branch.

Member

Fishrock123 commented Dec 5, 2016

force-pushed, landed in c8cf71d now.

@jasnell To answer your other question, this is effectively targeting the wrong branch.

Fishrock123 added a commit that referenced this pull request Dec 5, 2016

deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 added a commit that referenced this pull request Dec 5, 2016

deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@Fishrock123 Fishrock123 referenced this pull request Dec 5, 2016

Merged

v7.2.1 proposal #10127

2 of 2 tasks complete

jmdarling added a commit to jmdarling/node that referenced this pull request Dec 8, 2016

deps: upgrade npm to 3.10.10
PR-URL: nodejs#9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added a commit that referenced this pull request Dec 13, 2016

deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@hulbert

This comment has been minimized.

Show comment
Hide comment
@hulbert

hulbert Dec 15, 2016

Apologies if this is an inappropriate place to ask but any sense of when a 6.x.x release will go out with this? It is the single thing blocking us from switching to node 6.

Funnily enough we've had a branch w/ node 6 passing CI and then it broke as soon as we tried the 6.9.x LTS releases because of this.

hulbert commented Dec 15, 2016

Apologies if this is an inappropriate place to ask but any sense of when a 6.x.x release will go out with this? It is the single thing blocking us from switching to node 6.

Funnily enough we've had a branch w/ node 6 passing CI and then it broke as soon as we tried the 6.9.x LTS releases because of this.

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Dec 15, 2016

Member

@hulbert this is is staging. Expect an RC next week and a release in 3

Member

MylesBorins commented Dec 15, 2016

@hulbert this is is staging. Expect an RC next week and a release in 3

MylesBorins added a commit that referenced this pull request Dec 21, 2016

deps: upgrade npm to 3.10.10
PR-URL: #9847
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 21, 2016

Merged

V6.9.3 proposal #10394

MylesBorins added a commit to MylesBorins/node that referenced this pull request Jan 3, 2017

2016-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) nodejs#9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             nodejs#9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            nodejs#10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) nodejs#9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) nodejs#8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    nodejs#8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) nodejs#10103
    - improved support for generator functions (Teddy Katz)
      nodejs#9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) nodejs#9685

PR-URL: nodejs#10394

MylesBorins added a commit that referenced this pull request Jan 3, 2017

2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394

MylesBorins added a commit that referenced this pull request Jan 3, 2017

2017-01-03, Version 6.9.3 'Boron' (LTS) Release
This LTS release comes with 312 commits. This includes 229 that are
test related, 62 that are docs related, 17 which are build / tools
related, and 4 commits which are updates to dependencies.

Notable Changes:

* build:
  - shared library support is now working for AIX builds
    (Stewart Addison) #9675
* deps:
    - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
             #9847
    - *V8*: Destructuring of arrow function arguments via computed
            property no longer throws (Michaël Zasso)
            #10386)
* inspector:
  - /json/version returns object, not an object wrapped in an array
    (Ben Noordhuis) #9762
* module:
  - using --debug-brk and --eval together now works as expected
    (Kelvin Jin) #8876
* process:
  - improve performance of nextTick up to 20% (Evan Lucas)
    #8932
* repl:
    - the division operator will no longer be accidentally parsed as
      regex (Teddy Katz) #10103
    - improved support for generator functions (Teddy Katz)
      #9852
* timers:
  - Re canceling a cancelled timers will no longer throw
    (Jeremiah Senkpiel) #9685

PR-URL: #10394

imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017

2017-01-03, Version 6.9.3 'Boron' (LTS) Release
    This LTS release comes with 312 commits. This includes 229 that are
    test related, 62 that are docs related, 17 which are build / tools
    related, and 4 commits which are updates to dependencies.

    Notable Changes:

    * build:
      - shared library support is now working for AIX builds
        (Stewart Addison) nodejs/node#9675
    * deps:
        - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
                 nodejs/node#9847
        - *V8*: Destructuring of arrow function arguments via computed
                property no longer throws (Michaël Zasso)
                nodejs/node#10386)
    * inspector:
      - /json/version returns object, not an object wrapped in an array
        (Ben Noordhuis) nodejs/node#9762
    * module:
      - using --debug-brk and --eval together now works as expected
        (Kelvin Jin) nodejs/node#8876
    * process:
      - improve performance of nextTick up to 20% (Evan Lucas)
        nodejs/node#8932
    * repl:
        - the division operator will no longer be accidentally parsed as
          regex (Teddy Katz) nodejs/node#10103
        - improved support for generator functions (Teddy Katz)
          nodejs/node#9852
    * timers:
      - Re canceling a cancelled timers will no longer throw
        (Jeremiah Senkpiel) nodejs/node#9685

    PR-URL: nodejs/node#10394

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017

2017-01-03, Version 6.9.3 'Boron' (LTS) Release
    This LTS release comes with 312 commits. This includes 229 that are
    test related, 62 that are docs related, 17 which are build / tools
    related, and 4 commits which are updates to dependencies.

    Notable Changes:

    * build:
      - shared library support is now working for AIX builds
        (Stewart Addison) nodejs/node#9675
    * deps:
        - *npm*: upgrade npm to 3.10.10 (Rebecca Turner)
                 nodejs/node#9847
        - *V8*: Destructuring of arrow function arguments via computed
                property no longer throws (Michaël Zasso)
                nodejs/node#10386)
    * inspector:
      - /json/version returns object, not an object wrapped in an array
        (Ben Noordhuis) nodejs/node#9762
    * module:
      - using --debug-brk and --eval together now works as expected
        (Kelvin Jin) nodejs/node#8876
    * process:
      - improve performance of nextTick up to 20% (Evan Lucas)
        nodejs/node#8932
    * repl:
        - the division operator will no longer be accidentally parsed as
          regex (Teddy Katz) nodejs/node#10103
        - improved support for generator functions (Teddy Katz)
          nodejs/node#9852
    * timers:
      - Re canceling a cancelled timers will no longer throw
        (Jeremiah Senkpiel) nodejs/node#9685

    PR-URL: nodejs/node#10394

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment