Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: const, let and strictEqual in test-tls-0 #9948

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
@flekmatik
Copy link

commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Just a fix for a test

Description of change

Using const instead of var and strictEqual instead of equal in test/parallel/test-tls-0-dns-altname.js

@mscdex mscdex added the tls label Dec 1, 2016

@imyller imyller added code-and-learn and removed tls labels Dec 1, 2016

@mscdex mscdex added the tls label Dec 1, 2016

@cjihrig

cjihrig approved these changes Dec 4, 2016

test/parallel/test-tls-0-dns-altname.js Outdated
var cert = c.getPeerCertificate();
assert.equal(cert.subjectaltname,
const cert = c.getPeerCertificate();
assert.strictEqual(cert.subjectaltname,
'DNS:google.com\0.evil.com, ' +

This comment has been minimized.

Copy link
@jasnell

jasnell Dec 5, 2016

Member

Can you please align the arguments here?

@Trott Trott force-pushed the flekmatik:c-a-l_task37 branch to c2e2194 Dec 16, 2016

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 16, 2016

@jasnell To keep this moving, I addressed your nit on @flekmatik's behalf. PTAL and update your review if it's warranted. Thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/5432/

@Trott

This comment has been minimized.

Copy link
Member

commented Dec 21, 2016

ping @jasnell: Your nit has been addressed. Looks good to you now?

Trott added a commit to Trott/io.js that referenced this pull request Dec 22, 2016

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Dec 22, 2016

Landed in 004a100.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 22, 2016

targos added a commit that referenced this pull request Dec 26, 2016

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 27, 2016

Merged

V6.9.3 proposal #10394

@targos targos added land-on-v4.x and removed lts-watch-v4.x labels Dec 28, 2016

targos added a commit that referenced this pull request Dec 28, 2016

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@evanlucas evanlucas referenced this pull request Jan 3, 2017

Merged

v7.4.0 release proposal #10589

evanlucas added a commit that referenced this pull request Jan 3, 2017

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas added a commit that referenced this pull request Jan 4, 2017

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jan 23, 2017

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jan 24, 2017

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jan 24, 2017

Merged

v4.8.0 proposal #10973

MylesBorins added a commit that referenced this pull request Feb 1, 2017

test: refactor test-tls-0-dns-altname
* var -> const, let
* assert.equal() -> assert.strictEqual()

PR-URL: #9948
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.