Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use SerializedStyles type for css props #233

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
4 participants
@BeniCheni
Copy link
Contributor

commented Apr 8, 2019

Description

Improve type for emotion css props in code w. SerializedStyles (similar to pagination.tsx):

const link: SerializedStyles = css`

Related Issues

N/A

@codecov-io

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@e47be96). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage          ?   38.81%           
=========================================
  Files             ?       20           
  Lines             ?      237           
  Branches          ?       56           
=========================================
  Hits              ?       92           
  Misses            ?      144           
  Partials          ?        1
Impacted Files Coverage Δ
src/components/authors-list.tsx 100% <100%> (ø)
src/components/edit-link.tsx 100% <100%> (ø)
src/components/author.tsx 90.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47be96...4d34106. Read the comment docs.

@LaRuaNa

LaRuaNa approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

lovely 👍

@sagirk

sagirk approved these changes Apr 9, 2019

Copy link
Member

left a comment

LGTM! 🎉

@sagirk sagirk merged commit 7c2ffa6 into nodejs:master Apr 9, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@BeniCheni BeniCheni deleted the BeniCheni:typed-css branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.