From bcd4bf1e04bf9d3d5fee043eaf59d7fef4c6026d Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Fri, 27 Sep 2019 10:40:32 -0400 Subject: [PATCH 1/2] tools: remove husky I've honestly felt this has introduced more friction then what it helps us accomplish. Not convinced that consistent commit messages matter a ton on the site, especially since we are not doing anything with the commit messages e.g. changelog Fixes: https://github.com/nodejs/nodejs.dev/issues/321 --- package.json | 7 ------- 1 file changed, 7 deletions(-) diff --git a/package.json b/package.json index ab6a3b5718..16affe8d77 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,6 @@ "babel-jest": "^24.1.0", "babel-preset-gatsby": "^0.1.7", "codecov": "^3.3.0", - "husky": "^1.3.1", "identity-obj-proxy": "^3.0.0", "jest": "^24.1.0", "prettier": "^1.16.4", @@ -99,11 +98,5 @@ "collectCoverageFrom": [ "src/**/**.(ts|tsx|js)" ] - }, - "husky": { - "hooks": { - "commit-msg": "commitlint --edit $HUSKY_GIT_PARAMS", - "pre-push": "yarn format-check && yarn tslint" - } } } From 54c967e579de4a545398c6ca9f0e7b27bdaf5940 Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Thu, 3 Oct 2019 15:27:36 -0400 Subject: [PATCH 2/2] fixup: remove commitlint --- package.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/package.json b/package.json index 16affe8d77..b3b06837cf 100644 --- a/package.json +++ b/package.json @@ -56,8 +56,6 @@ "devDependencies": { "@babel/core": "^7.3.3", "@babel/preset-typescript": "^7.3.3", - "@commitlint/cli": "^8.1.0", - "@commitlint/config-conventional": "^7.3.1", "@types/jest": "^24.0.5", "@types/react-test-renderer": "^16.8.1", "babel-jest": "^24.1.0",