From 2f234aef2d194597df937bd2fcf295ae91af2643 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 19 Oct 2019 12:28:27 -0400 Subject: [PATCH 1/6] fix: no-trailing-spaces --- .remarkrc | 5 ----- CONTRIBUTING.md | 2 +- README.md | 1 - meetings/2018-02-15.md | 6 ++---- meetings/2018-03-01.md | 10 +--------- meetings/2018-03-15.md | 6 ++---- meetings/2018-03-29.md | 1 - meetings/2018-04-12.md | 1 - meetings/2018-05-10.md | 9 ++++----- meetings/2018-05-24.md | 1 - meetings/2018-09-13.md | 10 ++++------ meetings/2018-09-27.md | 3 +-- meetings/2018-1-17.md | 8 ++------ meetings/2018-12-06.md | 1 - meetings/2019-02-28.md | 11 ++++------- meetings/2019-03-14.md | 5 +---- meetings/2019-03-28.md | 6 ++---- meetings/2019-04-25.md | 9 +++------ 18 files changed, 27 insertions(+), 68 deletions(-) diff --git a/.remarkrc b/.remarkrc index 59707c684e..3a4e0d9834 100644 --- a/.remarkrc +++ b/.remarkrc @@ -8,12 +8,7 @@ ["remark-lint-list-item-bullet-indent", false], ["remark-lint-list-item-indent", false], ["remark-lint-maximum-line-length", false], - ["remark-lint-no-consecutive-blank-lines", false], - ["remark-lint-no-inline-padding", false], ["remark-lint-no-multiple-toplevel-headings", false], - ["remark-lint-no-shortcut-reference-link", false], - ["remark-lint-no-trailing-spaces", false], - ["remark-lint-no-undefined-references", false], ["remark-lint-unordered-list-marker-style", false] ] } diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ab2dd8c483..cb51482f4d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,7 +44,7 @@ Pull requests seeking to make any of the following changes do not need to wait 2 - There must be at least one sign off - There must be no objections after a 48 hour period -The default for each contribution is that it is accepted once no collaborator has an objection. During review collaborators may also request that a specific contributor who is most versed in a particular area gives a "LGTM" before the PR can be merged. +The default for each contribution is that it is accepted once no collaborator has an objection. During review collaborators may also request that a specific contributor who is most versed in a particular area gives a "LGTM" before the PR can be merged. In the case of an objection being raised in a pull request by another collaborator, all involved collaborators should seek to arrive at a consensus by way of addressing concerns being expressed by discussion, compromise on the proposed change, or withdrawal of the proposed change. diff --git a/README.md b/README.md index fec14ae1b5..a5067e504c 100644 --- a/README.md +++ b/README.md @@ -123,7 +123,6 @@ Looking for more guidance? Full documentation for Gatsby lives [on the website]( - **To dive straight into code samples head [to our documentation](https://next.gatsbyjs.org/docs/).** In particular, check out the “Guides”, API reference, and “Advanced Tutorials” sections in the sidebar. - ## 🏛 Governance This initiative adopts the general Node.js [Code of Conduct][], as well as its diff --git a/meetings/2018-02-15.md b/meetings/2018-02-15.md index 2aec431b69..3fbb47ecbc 100644 --- a/meetings/2018-02-15.md +++ b/meetings/2018-02-15.md @@ -20,7 +20,6 @@ Order in the agenda will be rearranged to prioritize issues https://chrome.google.com/webstore/detail/balsamiq-wireframes-for-d/jmebhflpaooegildgjfecegknjahhfki?hl=en * Sub-sites of nodejs.org - ### Getting started section #9 * Nodejitsu handed over their Knowledge Base, it’s not linked on the website yet. @@ -33,8 +32,8 @@ https://chrome.google.com/webstore/detail/balsamiq-wireframes-for-d/jmebhflpaooe ### Updating Node.js messaging #242 (in CommComm) * Also discussed in nodejs.org/#1534: Examples: - - http://styleguide.mailchimp.com
 - - http://voiceandtone.com + - http://styleguide.mailchimp.com + - http://voiceandtone.com * messaging is old and may have been outgrown * Existing content in Evangelism repo: Social Media Style Guide * Must make sure to collaborate with the Foundation to make sure of buy in @@ -49,4 +48,3 @@ https://chrome.google.com/webstore/detail/balsamiq-wireframes-for-d/jmebhflpaooe ## Timeline Review: * 2 week deliverables (architecture phase ongoing): real content for Learning, detailed wireframe - diff --git a/meetings/2018-03-01.md b/meetings/2018-03-01.md index 62b97108a0..95c1567826 100644 --- a/meetings/2018-03-01.md +++ b/meetings/2018-03-01.md @@ -14,14 +14,13 @@ Order in the agenda will be rearranged to prioritize issues ### Website Wireframes [#15](https://github.com/nodejs/website-redesign/issues/15) Context: We left the last meeting with an action item to have wireframes for discussion by next discussion. Adam makes first pass and put it together. Much activity, we notice visuals helps increase engagement. There are a lot of outstanding questions. Intent is broad strokes for site flow. -* Suggest prioritizing content. +* Suggest prioritizing content. * The largest point of discussion was how the download button works in the home page. Maybe set up three options and ask for feedback. * Analytics: There are analytics for the nodejs org site. We don’t have access but we can request from Zibby Keaton. Caution against putting too much stock in that instead of doing enough user exploration. * Goals: Clear navigation hierarchy that surfaces everything. Restructuring the current website that has several years of tacked on additions. * Content: Would want more content for this on Getting Started. * TODO: Open up a user personas issue. - ### Voice and Tone Guidelines [#13](https://github.com/nodejs/website-redesign/issues/13) * Prepare the document as if it could be used beyond the scope but the scope is unchanged. * TODO: Make clear in the doc, the use of humour and recommended voice for that. @@ -41,7 +40,6 @@ Context: Console/editor with which to test the capabilities of node. * Runkit: you don’t see package files which is arguably better for tutorials * The objective: We need to identify the feature set that best satisfies the needs of the code playground. - ### Getting started section [#9](https://github.com/nodejs/website-redesign/issues/9) * Past TODO: Investigate how frameworks and languages implement interactive Getting Started experiences * The purpose: onboard people on getting running from scratch. We should add more detailed getting started docs. @@ -49,23 +47,17 @@ Context: Console/editor with which to test the capabilities of node. * Is there a way within Getting Started to tie into NodeSchool and other community initiatives? For this, the workshoppers need to be updated (some are Node 4). These would need an official maintainer to ensure they’re up to date. * TODO: open a new issue to explore connecting to NodeSchool on Getting Started - ### Updating Node.js messaging [#242](https://github.com/nodejs/community-committee/issues/242) (in CommComm) * It’s good for a technical person coming to Nodejs for the first time, but not for other people. Focus on this for content building rather than in the content definition space. * Open an issue for this in /admin because it’s a huge org wide scope. - ### Overall site structure [#4](https://github.com/nodejs/website-redesign/issues/4) * past TODO: Set up balsamiq and get a GDoc configured with it - ### Notes * Can start iterating on parts of the site where significant discussion has been had. * TODO: Make doodle for new meeting time. Until then, meeting time remains the same - ## Timeline Review: * Suggested approach from earlier meeting: At the beginning of each section (eg. Architecture), estimate how long it’ll take, surface in the meeting, update as needed * 2018-02-15: 2 week deliverables (architecture phase ongoing): real content for Learning, detailed wireframe - - diff --git a/meetings/2018-03-15.md b/meetings/2018-03-15.md index eea38e0353..3a027e403f 100644 --- a/meetings/2018-03-15.md +++ b/meetings/2018-03-15.md @@ -27,9 +27,7 @@ TODO Tierney: Organize another meeting between NodeSchool and the Website Redesi ## Q&A, Other -#### - -#### IA Document Summary +#### IA Document Summary - Wireframes - Content Graph - Analytics @@ -46,7 +44,7 @@ TODO Tierney: Organize another meeting between NodeSchool and the Website Redesi - Minimal branding - Maintained - Cost - - Stdout / Console + - Stdout / Console ## Upcoming Meetings diff --git a/meetings/2018-03-29.md b/meetings/2018-03-29.md index c2c8c79186..eece07a88e 100644 --- a/meetings/2018-03-29.md +++ b/meetings/2018-03-29.md @@ -58,4 +58,3 @@ * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-04-12.md b/meetings/2018-04-12.md index 25575a5016..5caa128715 100644 --- a/meetings/2018-04-12.md +++ b/meetings/2018-04-12.md @@ -64,4 +64,3 @@ Welcome @codeekage to the team! Happy to have you! * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-05-10.md b/meetings/2018-05-10.md index 9985deb6a7..18c24bed9d 100644 --- a/meetings/2018-05-10.md +++ b/meetings/2018-05-10.md @@ -33,7 +33,7 @@ * Website Wireframes [#15](https://github.com/nodejs/website-redesign/issues/15) Removed from agenda, since we’ve moved on to Design -* Tech Exploration for In-Browser Node Playground +* Tech Exploration for In-Browser Node Playground [#12](https://github.com/nodejs/website-redesign/issues/12) Removed from Agenda, since we’ve moved on to design * Extended Color Palette [#42](https://github.com/nodejs/website-redesign/issues/42) @@ -46,14 +46,14 @@ What do you think of the extended color palette solution as a whole? I love hear - Ask to join marketing team meeting - Doesn’t look like it will conflict with existing brand -Dhruv: Do we fork existing libraries and keep it in Node.js so we have more control over design features? +Dhruv: Do we fork existing libraries and keep it in Node.js so we have more control over design features? Adam / Tierney: We want to minimize support costs! Where possible, lets point out to OSS we’re leveraging and calling “standard” to reduce our maintenance burdon. * Identify topics to discuss for Collab Summit Spring 2018 [#29](https://github.com/nodejs/website-redesign/issues/29) Francisco: Parallel bug to getting started content – what is the getting started experience? What are priorities of “getting started” and docs? -Tierney: Good place to coordinate with TSC and other members across org about how to maintain docs. +Tierney: Good place to coordinate with TSC and other members across org about how to maintain docs. - Intend to make docs more accessible - Developing user personas could support the case of making the docs more readable and accessible @@ -63,7 +63,7 @@ Tierney: Good place to coordinate with TSC and other members across org about ho Agreed to push 1hr back to not torture our USA West Coast members * Corporate Design Resource Donations -Tierney: Raised the possibility of soliciting designer resource donations from corporate foundation members. +Tierney: Raised the possibility of soliciting designer resource donations from corporate foundation members. Francisco: Stripe may be interested in providing these resources as well, on a well-defined timeline. Will talk with leads today and report back. Adam: This WG should function, among other things, as a design management body so as we have resources rotate in and out we still have a cohesive and unified project direction – we will happily take any resources we can get! There is always work :) @@ -74,4 +74,3 @@ Adam: This WG should function, among other things, as a design management body s * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-05-24.md b/meetings/2018-05-24.md index c32140c3bf..05990ac465 100644 --- a/meetings/2018-05-24.md +++ b/meetings/2018-05-24.md @@ -42,4 +42,3 @@ * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-09-13.md b/meetings/2018-09-13.md index 42e8506738..a6bede7e47 100644 --- a/meetings/2018-09-13.md +++ b/meetings/2018-09-13.md @@ -8,9 +8,9 @@ ## Present - - Manil Chowdhury (@chowdhurian) - - Tierney Cyren (@bnb) - - Adam Miller (@amiller-gh) + - Manil Chowdhury (@chowdhurian) + - Tierney Cyren (@bnb) + - Adam Miller (@amiller-gh) - Francisco Tomalsky (@tomalsky) ## Agenda @@ -72,10 +72,9 @@ Tierney provided extra context to add. Manil will work with the author at their **ACTION ITEM:** Manil – follow up with author of PR #83. - ## Q&A, Other -### Adam: Meetup docs hackathons? +### Adam: Meetup docs hackathons? **ACTION ITEM:** Adam make ticket for Meetup docs hackathons discussion. @@ -90,4 +89,3 @@ Tierney provided extra context to add. Manil will work with the author at their * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-09-27.md b/meetings/2018-09-27.md index bebaca6cb1..b669f6b061 100644 --- a/meetings/2018-09-27.md +++ b/meetings/2018-09-27.md @@ -14,7 +14,7 @@ * Tierney Cyren (@bnb) * Adam Miller (@amiller-gh) * Francisco Tomalsky (@tomalsky) - + ## Agenda ## Announcements @@ -58,4 +58,3 @@ ACTION ITEM @ammilelr-gh – Reach out to flavio. * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-1-17.md b/meetings/2018-1-17.md index 64f76cda0c..efcb2514b2 100644 --- a/meetings/2018-1-17.md +++ b/meetings/2018-1-17.md @@ -28,13 +28,11 @@ * \[Discussion\] - Tech Stack Consideration [#107](https://github.com/nodejs/website-redesign/issues/107) - - * Idea: Host Docs Hackathons [#99](https://github.com/nodejs/website-redesign/issues/99) * User Feedback: Node.js Docs Survey [#61](https://github.com/nodejs/website-redesign/issues/61) * Node.js Foundation Website IA - - Latest from Medium + - Latest from Medium - Homepage content – ensure it is covered by new HP. - Mention of member of the $FOUNDATION! In the “history” section of Learn? - Governance section? TSC / CommComm / WGs? @@ -47,12 +45,11 @@ - In the news. Tierney: Don’t think this is valuable for the nodejs website itself. Can live on new $FOUNDATION website. Not the target audience. Cut. - Events! Keep. Make better. - Newsletter: Foundation version likely going away with the merger, can possibly be a CommComm owned newsletter. Mohit: Can be a subscribe box/button somewhere, not a full page. - - Speakers Buerau: Need to check status post Zibby. + - Speakers Buerau: Need to check status post Zibby. - Resources for Event Org: Keep. Make better. Talk more. - Store: keep link. - Keep: Social media links. - ## Q&A, Other ## Upcoming Meetings @@ -60,4 +57,3 @@ * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2018-12-06.md b/meetings/2018-12-06.md index f1600a77d4..7e1dae8241 100644 --- a/meetings/2018-12-06.md +++ b/meetings/2018-12-06.md @@ -48,7 +48,6 @@ One of the suggestions was to include a happy-neutral-sad face on the docs. Good Person may know what’s wrong but not not have a way to request edits No action items in website-redesign. - ## Q&A, Other ## Upcoming Meetings diff --git a/meetings/2019-02-28.md b/meetings/2019-02-28.md index fe112e5901..a665ddf10f 100644 --- a/meetings/2019-02-28.md +++ b/meetings/2019-02-28.md @@ -6,12 +6,10 @@ * **GitHub Issue**: https://github.com/nodejs/website-redesign/issues/146 * **Minutes Google Doc**: https://docs.google.com/document/d/1JizrFXDqS7T3RzwuGELUBytBD3fBHn-Pzc2XuY5SrS8/edit - ## Present * Website Redesign Strategic Initiative Team: @nodejs/website-redesign - ## Agenda ## Announcements @@ -20,12 +18,12 @@ nodejs/nodejs.dev * Turning off "merge" button [#103](https://github.com/nodejs/nodejs.dev/issues/103) -* Review the prettierrc and adapt "best practice" +* Review the prettierrc and adapt "best practice" [#44](https://github.com/nodejs/nodejs.dev/issues/44) Onur: Changing one rule, investigating tslint<->prettier automation, re-running #97 and pulling in all / closing issues. -* How do we want to add new members? +* How do we want to add new members? [#127](https://github.com/nodejs/nodejs.dev/issues/127) No objections on the channel to process in the ticket. 3 PRs is guidance, not policy. @@ -46,7 +44,7 @@ TODO: Sagir to add a link to CC and update the decision on no periods in CONTRIB Removing label. Will keep this in mind as we design next pages. -* User Feedback: Node.js Docs Survey +* User Feedback: Node.js Docs Survey [#61](https://github.com/nodejs/website-redesign/issues/61) Consensus: Still want to execute on this. @@ -54,7 +52,7 @@ TODO: Agiri to take to User Feedback meeting tomorrow. * New Home: Nodejs.dev [#147](https://github.com/nodejs/website-redesign/issues/147) -Sagir: Wasn’t aware of the sister repo before – consolidating would be good. +Sagir: Wasn’t aware of the sister repo before – consolidating would be good. Ahmad: Seconded – meeting notes in the .dev repo would encourage contribution. Agiri: A little concerned about clutter, moving meeting minutes in to dev repo – will need to work on content structure to keep organized, otherwise ok. TODO: Adam to move over content @@ -66,4 +64,3 @@ TODO: Adam to move over content * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2019-03-14.md b/meetings/2019-03-14.md index 6af6ed3c02..5bcd05dd60 100644 --- a/meetings/2019-03-14.md +++ b/meetings/2019-03-14.md @@ -26,7 +26,6 @@ We’ll need to have a governance chat. It will eventually merge into nodejs.org Nodejs.dev could be used as a starting point for devs later. AI: Add website-redesign intro to the nodejs.dev repo - * User Feedback: Node.js Docs Survey [#61](https://github.com/nodejs/website-redesign/issues/61) AI: Sync with user-feedback initiative on whether the user feedback meetups can incorporate this @@ -41,8 +40,7 @@ No decision made, tabled for next meeting. * Navigation / Section Proposal [#169](https://github.com/nodejs/nodejs.dev/issues/169) -For now, we need more data on this issue so keeping it open for now. - +For now, we need more data on this issue so keeping it open for now. ## Q&A, Other @@ -51,4 +49,3 @@ For now, we need more data on this issue so keeping it open for now. * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2019-03-28.md b/meetings/2019-03-28.md index e5cfbcab56..8d8c970690 100644 --- a/meetings/2019-03-28.md +++ b/meetings/2019-03-28.md @@ -19,7 +19,6 @@ - Ahmad Awais (@AhmadAwais) - Maedah Batool (@MaedahBatool) - ## Agenda ## Announcements @@ -45,13 +44,13 @@ Zeke: How to consume localized API docs * Navigation / Section Proposal [#169](https://github.com/nodejs/nodejs.dev/issues/169) -* Discussion: report code coverage during travis builds [#206] https://github.com/nodejs/nodejs.dev/issues/206 +* Discussion: report code coverage during travis builds [#206] https://github.com/nodejs/nodejs.dev/issues/206 * Discussion: Alternate solutions to provide credit [#201](https://github.com/nodejs/nodejs.dev/issues/201) Awais: We can probably use the `.png` after GitHub user profile links to generate a profile image (provided we have the consent, something we could automate via open source consent bot). -E.g. +E.g. Profile: https://github.com/AhmadAwais Profile Image: https://github.com/AhmadAwais.png @@ -72,4 +71,3 @@ Doesn't seem to be rate limited by looking at the rate.remaining property. * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - diff --git a/meetings/2019-04-25.md b/meetings/2019-04-25.md index 9ca07d30f4..f776e42b46 100644 --- a/meetings/2019-04-25.md +++ b/meetings/2019-04-25.md @@ -27,12 +27,12 @@ Website Redesign Strategic Initiative Team: @nodejs/website-redesign #### Node.js Foundation Website Redesign Brief 2019-03-28 [#157](https://github.com/nodejs/website-redesign/issues/157) * There is a form to share * The User Feedback Initiative can help with privacy issues - * Foundation will share through org twitter + * Foundation will share through org twitter * Existing analytics data for the current .org site shows that most people stay on the homepage. Only 4pc go to docs. Most are new visitors. Good opportunity to direct to tutorials. * https://github.com/nodejs/website-redesign/issues/45 - * 
https://github.com/nodejs/website-redesign/issues/4 + * https://github.com/nodejs/website-redesign/issues/4 * Begun working on a stylesheet (color, iconography, grid, typography, and so on) - * our assets: https://nodejs.org/en/about/resources/
 + * our assets: https://nodejs.org/en/about/resources/ #### Create data contract for how API documentation will be consumed [#158](https://github.com/nodejs/website-redesign/issues/158) @@ -49,8 +49,6 @@ Website Redesign Strategic Initiative Team: @nodejs/website-redesign * “Does your company use Node.js?” is better pushed by the CommComm * Todo: Tierney to create an issue in CommComm - - ## Q&A, Other ## Upcoming Meetings @@ -58,4 +56,3 @@ Website Redesign Strategic Initiative Team: @nodejs/website-redesign * **Node.js Foundation Calendar**: https://nodejs.org/calendar Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. - From cb327ac8898c2a79f9084178620d32443b87fe8c Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Fri, 20 Dec 2019 14:26:05 -0500 Subject: [PATCH 2/6] fix: no-shortcut-reference-link --- meetings/2018-05-31.md | 4 ++-- meetings/2019-03-28.md | 2 +- style-guide/0001-voice-and-tone.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/meetings/2018-05-31.md b/meetings/2018-05-31.md index 75849b2788..1c466ef4f0 100644 --- a/meetings/2018-05-31.md +++ b/meetings/2018-05-31.md @@ -42,8 +42,8 @@ have left us desiring content for guides. **Adam**: A couple blockers we can see in the future. Issue [#13](https://github.com/nodejs/website-redesign/issues/13), is most important. -The tech exploration is ongoing ([#12](https://github.com/nodejs/website- -redesign/issues/12)). There will almost certainly be some religious debates +The tech exploration is ongoing ([#12](https://github.com/nodejs/website-redesign/issues/12) +). There will almost certainly be some religious debates (what should we be documenting), should we have an Express example? These are big questions, and we should have these offline. diff --git a/meetings/2019-03-28.md b/meetings/2019-03-28.md index 8d8c970690..84e1b8f803 100644 --- a/meetings/2019-03-28.md +++ b/meetings/2019-03-28.md @@ -44,7 +44,7 @@ Zeke: How to consume localized API docs * Navigation / Section Proposal [#169](https://github.com/nodejs/nodejs.dev/issues/169) -* Discussion: report code coverage during travis builds [#206] https://github.com/nodejs/nodejs.dev/issues/206 +* Discussion: report code coverage during travis builds [#206](https://github.com/nodejs/nodejs.dev/issues/206) * Discussion: Alternate solutions to provide credit [#201](https://github.com/nodejs/nodejs.dev/issues/201) diff --git a/style-guide/0001-voice-and-tone.md b/style-guide/0001-voice-and-tone.md index 76e7e757db..9b5e3d9a99 100644 --- a/style-guide/0001-voice-and-tone.md +++ b/style-guide/0001-voice-and-tone.md @@ -114,7 +114,7 @@ They might say: _"How do I load another .js file and run that new .js file in a global context?..."_ We might respond: _"This would not be recommended. The reason for this suggestion -is [insert reason here]. You might also want to take a look at..."_ +is \[insert reason here\]. You might also want to take a look at..."_ The response above is direct, yet respectful. It is straightforward and answers the question with a concrete suggestion. It invites, rather than commands, the person From 21b578aa68723e79a13bb4bcd0fed394e30aa3a9 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 19 Oct 2019 12:35:36 -0400 Subject: [PATCH 3/6] fix: list-item-indent --- .remarkrc | 2 -- README.md | 44 ++++++++++++++++++------------------- meetings/2018-03-15.md | 4 ++-- meetings/2018-05-10.md | 12 +++++----- meetings/2018-05-24.md | 20 ++++++++--------- meetings/2018-09-13.md | 8 +++---- meetings/2018-1-17.md | 32 +++++++++++++-------------- meetings/2019-04-25.md | 24 ++++++++++---------- src/documentation/README.md | 16 +++++++------- 9 files changed, 80 insertions(+), 82 deletions(-) diff --git a/.remarkrc b/.remarkrc index 3a4e0d9834..aeb7f2f543 100644 --- a/.remarkrc +++ b/.remarkrc @@ -5,8 +5,6 @@ ["remark-lint-code-block-style", false], ["remark-lint-fenced-code-flag", false], ["remark-lint-first-heading-level", false], - ["remark-lint-list-item-bullet-indent", false], - ["remark-lint-list-item-indent", false], ["remark-lint-maximum-line-length", false], ["remark-lint-no-multiple-toplevel-headings", false], ["remark-lint-unordered-list-marker-style", false] diff --git a/README.md b/README.md index a5067e504c..da57acdab1 100644 --- a/README.md +++ b/README.md @@ -26,11 +26,11 @@ ## 🚀 Get Started -1. **Install Yarn (if Yarn Package Manager is not available on your machine).** +1. **Install Yarn (if Yarn Package Manager is not available on your machine).** Yarn has an [installation guide](https://yarnpkg.com/en/docs/install) for your specific configuration. Happy knitting! -2. **Install dependencies.** +2. **Install dependencies.** ```sh # install the dependencies @@ -44,7 +44,7 @@ yarn start ``` -4. **Open the source code and start editing!** +4. **Open the source code and start editing!** Your site is now running at `http://localhost:8000`! @@ -73,39 +73,39 @@ A quick look at the top-level files and directories you'll see in a Gatsby proje ├── tslint.json └── yarn.lock - 1. **`/node_modules`**: The directory where all of the modules of code that your project depends on (npm packages) are automatically installed. +1. **`/node_modules`**: The directory where all of the modules of code that your project depends on (npm packages) are automatically installed. - 2. **`/src`**: This directory will contain all of the code related to what you will see on the front-end of your site (what you see in the browser), like your site header, or a page template. “Src” is a convention for “source code.” +2. **`/src`**: This directory will contain all of the code related to what you will see on the front-end of your site (what you see in the browser), like your site header, or a page template. “Src” is a convention for “source code.” - 3. **`.gitignore`**: This file tells git which files it should not track/not maintain a version history. +3. **`.gitignore`**: This file tells git which files it should not track/not maintain a version history. - 4. **`.nvmrc`**: NVM configuration so packages work as they should +4. **`.nvmrc`**: NVM configuration so packages work as they should - 5. **`.prettierrc`**: This is a configuration file for a tool called [Prettier](https://prettier.io/), which is a tool to help keep the formatting of your code consistent. +5. **`.prettierrc`**: This is a configuration file for a tool called [Prettier](https://prettier.io/), which is a tool to help keep the formatting of your code consistent. - 6. **`empty.env`**: Rename to **`.env`** and set your Contentful API key +6. **`empty.env`**: Rename to **`.env`** and set your Contentful API key - 7. **`gatsby-browser.tsx`**: This file is where Gatsby expects to find any usage of the [Gatsby browser APIs](https://next.gatsbyjs.org/docs/browser-apis/) (if any). These allow customization/extension of default Gatsby settings affecting the browser. +7. **`gatsby-browser.tsx`**: This file is where Gatsby expects to find any usage of the [Gatsby browser APIs](https://next.gatsbyjs.org/docs/browser-apis/) (if any). These allow customization/extension of default Gatsby settings affecting the browser. - 6. **`gatsby-config.js`**: This is the main configuration file for a Gatsby site. This is where you can specify information about your site (metadata) like the site title and description, which Gatsby plugins you’d like to include, etc. (Check out the [config docs](https://next.gatsbyjs.org/docs/gatsby-config/) for more detail). +6. **`gatsby-config.js`**: This is the main configuration file for a Gatsby site. This is where you can specify information about your site (metadata) like the site title and description, which Gatsby plugins you’d like to include, etc. (Check out the [config docs](https://next.gatsbyjs.org/docs/gatsby-config/) for more detail). - 8. **`gatsby-node.js`**: This file is where Gatsby expects to find any usage of the [Gatsby node APIs](https://next.gatsbyjs.org/docs/node-apis/) (if any). These allow customization/extension of default Gatsby settings affecting pieces of the site build process. +8. **`gatsby-node.js`**: This file is where Gatsby expects to find any usage of the [Gatsby node APIs](https://next.gatsbyjs.org/docs/node-apis/) (if any). These allow customization/extension of default Gatsby settings affecting pieces of the site build process. - 9. **`gatsby-ssr.tsx`**: This file is where Gatsby expects to find any usage of the [Gatsby server-side rendering APIs](https://next.gatsbyjs.org/docs/ssr-apis/) (if any). These allow customization of default Gatsby settings affecting server-side rendering. +9. **`gatsby-ssr.tsx`**: This file is where Gatsby expects to find any usage of the [Gatsby server-side rendering APIs](https://next.gatsbyjs.org/docs/ssr-apis/) (if any). These allow customization of default Gatsby settings affecting server-side rendering. - 10. **`LICENSE`**: Gatsby is licensed under the MIT license. +10. **`LICENSE`**: Gatsby is licensed under the MIT license. - 11. **`package-lock.json`** (See `package.json` below, first). This is an automatically generated file based on the exact versions of your npm dependencies that were installed for your project. (You won’t change this file directly). +11. **`package-lock.json`** (See `package.json` below, first). This is an automatically generated file based on the exact versions of your npm dependencies that were installed for your project. (You won’t change this file directly). - 12. **`package.json`**: A manifest file for Node.js projects, which includes things like metadata (the project’s name, author, etc.). This manifest is how npm knows which packages to install for your project. +12. **`package.json`**: A manifest file for Node.js projects, which includes things like metadata (the project’s name, author, etc.). This manifest is how npm knows which packages to install for your project. - 13. **`README.md`**: A text file containing useful reference information about your project. +13. **`README.md`**: A text file containing useful reference information about your project. - 14. **`tsconfig.json`**: Config file for TypeScript +14. **`tsconfig.json`**: Config file for TypeScript - 15. **`tslint.json`**: TS Lint configuration file +15. **`tslint.json`**: TS Lint configuration file - 16. **`yarn.lock`**: [Yarn](https://yarnpkg.com/) is a package manager alternative to npm. You can use either yarn or npm, though all of the Gatsby docs reference npm. This file serves essentially the same purpose as `package-lock.json`, just for a different package management system. +16. **`yarn.lock`**: [Yarn](https://yarnpkg.com/) is a package manager alternative to npm. You can use either yarn or npm, though all of the Gatsby docs reference npm. This file serves essentially the same purpose as `package-lock.json`, just for a different package management system. ## 📝 Data Sources @@ -119,9 +119,9 @@ The `src/documentation` directory currently contains all the getting started con Looking for more guidance? Full documentation for Gatsby lives [on the website](https://next.gatsbyjs.org/). Here are some places to start: -- **For most developers, we recommend starting with our [in-depth tutorial for creating a site with Gatsby](https://next.gatsbyjs.org/tutorial/).** It starts with zero assumptions about your level of ability and walks through every step of the process. +- **For most developers, we recommend starting with our [in-depth tutorial for creating a site with Gatsby](https://next.gatsbyjs.org/tutorial/).** It starts with zero assumptions about your level of ability and walks through every step of the process. -- **To dive straight into code samples head [to our documentation](https://next.gatsbyjs.org/docs/).** In particular, check out the “Guides”, API reference, and “Advanced Tutorials” sections in the sidebar. +- **To dive straight into code samples head [to our documentation](https://next.gatsbyjs.org/docs/).** In particular, check out the “Guides”, API reference, and “Advanced Tutorials” sections in the sidebar. ## 🏛 Governance diff --git a/meetings/2018-03-15.md b/meetings/2018-03-15.md index 3a027e403f..f187108691 100644 --- a/meetings/2018-03-15.md +++ b/meetings/2018-03-15.md @@ -17,8 +17,8 @@ #### Getting started with node [#9](https://github.com/nodejs/website-redesign/issues/9) * Some of this could actually go into Learn section * For the embedded runtime: What do we want? - * We want people to be able to jump in and use it without having the install dependencies - * We want to build up from JS knowledge and take users into using Node + * We want people to be able to jump in and use it without having the install dependencies + * We want to build up from JS knowledge and take users into using Node * Do we want to also guide through Express or just explain Node core? The power of Node is the ecosystem and we should strike a balance. Take a look at how NodeSchool separates Core workshoppers from Electives. TODO Tierney: Organize another meeting between NodeSchool and the Website Redesign Initiative diff --git a/meetings/2018-05-10.md b/meetings/2018-05-10.md index 18c24bed9d..6fa19c26c8 100644 --- a/meetings/2018-05-10.md +++ b/meetings/2018-05-10.md @@ -10,12 +10,12 @@ * Website Redesign Strategic Initiative Team: @nodejs/website-redesign - - Tierney Cyren (@bnb) - - Adam Miller (@amiller-gh) - - Dhruv Jain (@maddhruv) - - Agiri Abraham Jr (@codeekage) - - Manil (@chowdhurian) - - Mark Hinkle + - Tierney Cyren (@bnb) + - Adam Miller (@amiller-gh) + - Dhruv Jain (@maddhruv) + - Agiri Abraham Jr (@codeekage) + - Manil (@chowdhurian) + - Mark Hinkle ## Agenda diff --git a/meetings/2018-05-24.md b/meetings/2018-05-24.md index 05990ac465..900b198c51 100644 --- a/meetings/2018-05-24.md +++ b/meetings/2018-05-24.md @@ -8,11 +8,11 @@ ## Present - - @amiller-gh - - @bnb - - @chowdhurian - - @detrohutt - - @maddhruv +- @amiller-gh +- @bnb +- @chowdhurian +- @detrohutt +- @maddhruv * Website Redesign Strategic Initiative Team: @nodejs/website-redesign @@ -27,13 +27,13 @@ * Node.js Extended Color Palette [#42](https://github.com/nodejs/website-redesign/issues/42) * Identify topics to discuss for Collab Summit Spring 2018 [#29](https://github.com/nodejs/website-redesign/issues/29) - - Adam and Manil will iterate over the weekend - - Greg Wallace in marketing for Linux Foundation would be welcome for the messaging update - - Make an invitation list of stakeholders. Runkit team is coming specifically for this session. - - Add “Improve docs” to list of discussion items. Maybe a separate session. + - Adam and Manil will iterate over the weekend + - Greg Wallace in marketing for Linux Foundation would be welcome for the messaging update + - Make an invitation list of stakeholders. Runkit team is coming specifically for this session. + - Add “Improve docs” to list of discussion items. Maybe a separate session. * Design update - - Runkit will secure design resources. We’ll followup by email. + - Runkit will secure design resources. We’ll followup by email. ## Q&A, Other diff --git a/meetings/2018-09-13.md b/meetings/2018-09-13.md index a6bede7e47..7d45aa33fd 100644 --- a/meetings/2018-09-13.md +++ b/meetings/2018-09-13.md @@ -8,10 +8,10 @@ ## Present - - Manil Chowdhury (@chowdhurian) - - Tierney Cyren (@bnb) - - Adam Miller (@amiller-gh) - - Francisco Tomalsky (@tomalsky) +- Manil Chowdhury (@chowdhurian) +- Tierney Cyren (@bnb) +- Adam Miller (@amiller-gh) +- Francisco Tomalsky (@tomalsky) ## Agenda diff --git a/meetings/2018-1-17.md b/meetings/2018-1-17.md index efcb2514b2..a4442ccfce 100644 --- a/meetings/2018-1-17.md +++ b/meetings/2018-1-17.md @@ -32,23 +32,23 @@ * User Feedback: Node.js Docs Survey [#61](https://github.com/nodejs/website-redesign/issues/61) * Node.js Foundation Website IA - - Latest from Medium - - Homepage content – ensure it is covered by new HP. - - Mention of member of the $FOUNDATION! In the “history” section of Learn? - - Governance section? TSC / CommComm / WGs? - - Individual membership!?!?!?!? Needs more definition. - - Application Showcase + - Latest from Medium + - Homepage content – ensure it is covered by new HP. + - Mention of member of the $FOUNDATION! In the “history” section of Learn? + - Governance section? TSC / CommComm / WGs? + - Individual membership!?!?!?!? Needs more definition. + - Application Showcase - Tierney: Has this driven value? If it has, awesome, if it hasn’t drop / improve? - - Certification Program - - Spotlight Videos – maybe? Rachel: How do they perform? Will get numbers. Largely just a pivot page to YouTube – likely cut. - - Announcements page – maybe just live on Medium? How to reconcile with release announcement page? Can we automate? Can we list latest medium articles anyway? - - In the news. Tierney: Don’t think this is valuable for the nodejs website itself. Can live on new $FOUNDATION website. Not the target audience. Cut. - - Events! Keep. Make better. - - Newsletter: Foundation version likely going away with the merger, can possibly be a CommComm owned newsletter. Mohit: Can be a subscribe box/button somewhere, not a full page. - - Speakers Buerau: Need to check status post Zibby. - - Resources for Event Org: Keep. Make better. Talk more. - - Store: keep link. - - Keep: Social media links. + - Certification Program + - Spotlight Videos – maybe? Rachel: How do they perform? Will get numbers. Largely just a pivot page to YouTube – likely cut. + - Announcements page – maybe just live on Medium? How to reconcile with release announcement page? Can we automate? Can we list latest medium articles anyway? + - In the news. Tierney: Don’t think this is valuable for the nodejs website itself. Can live on new $FOUNDATION website. Not the target audience. Cut. + - Events! Keep. Make better. + - Newsletter: Foundation version likely going away with the merger, can possibly be a CommComm owned newsletter. Mohit: Can be a subscribe box/button somewhere, not a full page. + - Speakers Buerau: Need to check status post Zibby. + - Resources for Event Org: Keep. Make better. Talk more. + - Store: keep link. + - Keep: Social media links. ## Q&A, Other diff --git a/meetings/2019-04-25.md b/meetings/2019-04-25.md index f776e42b46..9ba84dd3c0 100644 --- a/meetings/2019-04-25.md +++ b/meetings/2019-04-25.md @@ -25,29 +25,29 @@ Website Redesign Strategic Initiative Team: @nodejs/website-redesign ### nodejs/website-redesign #### Node.js Foundation Website Redesign Brief 2019-03-28 [#157](https://github.com/nodejs/website-redesign/issues/157) - * There is a form to share - * The User Feedback Initiative can help with privacy issues - * Foundation will share through org twitter - * Existing analytics data for the current .org site shows that most people stay on the homepage. Only 4pc go to docs. Most are new visitors. Good opportunity to direct to tutorials. - * https://github.com/nodejs/website-redesign/issues/45 - * https://github.com/nodejs/website-redesign/issues/4 - * Begun working on a stylesheet (color, iconography, grid, typography, and so on) - * our assets: https://nodejs.org/en/about/resources/ +* There is a form to share +* The User Feedback Initiative can help with privacy issues +* Foundation will share through org twitter +* Existing analytics data for the current .org site shows that most people stay on the homepage. Only 4pc go to docs. Most are new visitors. Good opportunity to direct to tutorials. +* https://github.com/nodejs/website-redesign/issues/45 +* https://github.com/nodejs/website-redesign/issues/4 +* Begun working on a stylesheet (color, iconography, grid, typography, and so on) +* our assets: https://nodejs.org/en/about/resources/ #### Create data contract for how API documentation will be consumed [#158](https://github.com/nodejs/website-redesign/issues/158) #### Consuming localized docs from `nodejs-i18n` module [#76](https://github.com/nodejs/website-redesign/issues/76) - * Todo: Ben to resolve #76, set up website-redesign/i18n ‘consuming the i18n module’ meeting. +* Todo: Ben to resolve #76, set up website-redesign/i18n ‘consuming the i18n module’ meeting. ### nodejs/nodejs.dev #### Self-Nomination to add BeniCheni as Collaborator? [#243](https://github.com/nodejs/nodejs.dev/issues/243) - * Resolved +* Resolved * https://github.com/nodejs/website-redesign/issues/15 - * “Does your company use Node.js?” is better pushed by the CommComm - * Todo: Tierney to create an issue in CommComm + * “Does your company use Node.js?” is better pushed by the CommComm + * Todo: Tierney to create an issue in CommComm ## Q&A, Other diff --git a/src/documentation/README.md b/src/documentation/README.md index a484835193..03c784e519 100644 --- a/src/documentation/README.md +++ b/src/documentation/README.md @@ -12,15 +12,15 @@ If you submit a pull request to implement a significant change to the documentat ## To begin drafting a documentation page: - 1. Fork the [nodejs/website-redesign repo](https://github.com/nodejs/website-redesign) so that you have your own copy of the repository that you have push access to. - 2. Create a new folder for your documentation to live in by copying the given template folder found at `documentation/0000-template` to a new folder `documentation/0000-my-article-name` (replacing 'my-article-name' with a descriptive name of what your article is about. Leave the 0000 as it is, since we don't need to assign your article a page number yet). - 3. You should now have a new folder that contains an article.md file that will serve as the template that you will use for your documentation. Edit this article.md file and begin writing out your article. Put care into the details! Please review the proposed [Node.js Voice and Tone Guidelines](https://github.com/nodejs/website-redesign/blob/master/style-guide/0001-voice-and-tone.md) before you begin writing. - 4. When you are ready to get some feedback on your article, submit a pull request back to the main nodejs/website-redesign repository. As a pull request, the draft will receive feedback from the larger community, and the author should be prepared to revise it in response. - 5. Build consensus on your article by integrating feedback from the community. - 6. Eventually, the Website Redesign Working Group will decide in one of their bi-weekly meetings whether the RFC is a candidate for inclusion on the Node.js website. +1. Fork the [nodejs/website-redesign repo](https://github.com/nodejs/website-redesign) so that you have your own copy of the repository that you have push access to. +2. Create a new folder for your documentation to live in by copying the given template folder found at `documentation/0000-template` to a new folder `documentation/0000-my-article-name` (replacing 'my-article-name' with a descriptive name of what your article is about. Leave the 0000 as it is, since we don't need to assign your article a page number yet). +3. You should now have a new folder that contains an article.md file that will serve as the template that you will use for your documentation. Edit this article.md file and begin writing out your article. Put care into the details! Please review the proposed [Node.js Voice and Tone Guidelines](https://github.com/nodejs/website-redesign/blob/master/style-guide/0001-voice-and-tone.md) before you begin writing. +4. When you are ready to get some feedback on your article, submit a pull request back to the main nodejs/website-redesign repository. As a pull request, the draft will receive feedback from the larger community, and the author should be prepared to revise it in response. +5. Build consensus on your article by integrating feedback from the community. +6. Eventually, the Website Redesign Working Group will decide in one of their bi-weekly meetings whether the RFC is a candidate for inclusion on the Node.js website. RFCs that are candidates for inclusion on the Node.js website will enter a "final comment period" lasting 7 days. The beginning of this period will be signaled with a comment and tag on the RFC's pull request. The RFC can be modified based upon feedback from the community. Significant modifications may trigger a new final comment period. At the close of this review period, the RFC may be: - * accepted at the close of its final comment period. A working group member will merge the RFC's associated pull request, at which point the RFC will become 'active', or; +* accepted at the close of its final comment period. A working group member will merge the RFC's associated pull request, at which point the RFC will become 'active', or; - * rejected by the Website Redesign working group after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the working group should then close the RFC's associated pull request. +* rejected by the Website Redesign working group after public discussion has settled and comments have been made summarizing the rationale for rejection. A member of the working group should then close the RFC's associated pull request. From 846a66c1576ad62c138a7f90efee4665ab146a2f Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 19 Oct 2019 12:38:45 -0400 Subject: [PATCH 4/6] fix: code-block-style --- .remarkrc | 1 - README.md | 38 ++++++++++++++++++++------------------ 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/.remarkrc b/.remarkrc index aeb7f2f543..1da1d298d4 100644 --- a/.remarkrc +++ b/.remarkrc @@ -2,7 +2,6 @@ "plugins": [ "remark-frontmatter", "remark-preset-lint-node", - ["remark-lint-code-block-style", false], ["remark-lint-fenced-code-flag", false], ["remark-lint-first-heading-level", false], ["remark-lint-maximum-line-length", false], diff --git a/README.md b/README.md index da57acdab1..27f6625ebe 100644 --- a/README.md +++ b/README.md @@ -54,24 +54,26 @@ A quick look at the top-level files and directories you'll see in a Gatsby project. - . - ├── node_modules - ├── src - ├── .gitignore - ├── .nvmrc - ├── .prettierrc - ├── empty.env - ├── gatsby-browser.js - ├── gatsby-config.js - ├── gatsby-node.js - ├── gatsby-ssr.js - ├── LICENSE - ├── package-lock.json - ├── package.json - ├── README.md - ├── tsconfig.json - ├── tslint.json - └── yarn.lock +```console +. +├── node_modules +├── src +├── .gitignore +├── .nvmrc +├── .prettierrc +├── empty.env +├── gatsby-browser.js +├── gatsby-config.js +├── gatsby-node.js +├── gatsby-ssr.js +├── LICENSE +├── package-lock.json +├── package.json +├── README.md +├── tsconfig.json +├── tslint.json +└── yarn.lock +``` 1. **`/node_modules`**: The directory where all of the modules of code that your project depends on (npm packages) are automatically installed. From ffb50422ac14f3b2e150b9e1de32e4770ccad3c2 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 19 Oct 2019 12:41:17 -0400 Subject: [PATCH 5/6] fix: fenced-code-flag --- .remarkrc | 1 - src/documentation/0011-node-repl/index.md | 2 +- src/documentation/0016-npm/index.md | 12 ++++++------ src/documentation/0028-npx/index.md | 2 +- src/documentation/0055-node-inspect-object/index.md | 2 +- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/.remarkrc b/.remarkrc index 1da1d298d4..47da49805c 100644 --- a/.remarkrc +++ b/.remarkrc @@ -2,7 +2,6 @@ "plugins": [ "remark-frontmatter", "remark-preset-lint-node", - ["remark-lint-fenced-code-flag", false], ["remark-lint-first-heading-level", false], ["remark-lint-maximum-line-length", false], ["remark-lint-no-multiple-toplevel-headings", false], diff --git a/src/documentation/0011-node-repl/index.md b/src/documentation/0011-node-repl/index.md index 3e55b568d0..8d476dfef4 100644 --- a/src/documentation/0011-node-repl/index.md +++ b/src/documentation/0011-node-repl/index.md @@ -32,7 +32,7 @@ The REPL is waiting for us to enter some JavaScript code, to be more precise. Start simple and enter -``` +```console > console.log('test') test undefined diff --git a/src/documentation/0016-npm/index.md b/src/documentation/0016-npm/index.md index cefccd4980..fcd6bf1154 100644 --- a/src/documentation/0016-npm/index.md +++ b/src/documentation/0016-npm/index.md @@ -50,7 +50,7 @@ The difference is mainly that devDependencies are usually development tools, lik Updating is also made easy, by running -``` +```console npm update ``` @@ -58,7 +58,7 @@ npm update You can specify a single package to update as well: -``` +```console npm update ``` @@ -78,13 +78,13 @@ In all those cases, versioning helps a lot, and `npm` follows the semantic versi The package.json file supports a format for specifying command line tasks that can be run by using -``` +```console npm run ``` For example: -```js +```json { "scripts": { "start-dev": "node lib/server-development", @@ -95,7 +95,7 @@ For example: It's very common to use this feature to run Webpack: -```js +```json { "scripts": { "watch": "webpack --watch --progress --colors --config webpack.conf.js", @@ -107,7 +107,7 @@ It's very common to use this feature to run Webpack: So instead of typing those long commands, which are easy to forget or mistype, you can run -``` +```console $ npm run watch $ npm run dev $ npm run prod diff --git a/src/documentation/0028-npx/index.md b/src/documentation/0028-npx/index.md index 5ae59b36d6..5f9b4536bd 100644 --- a/src/documentation/0028-npx/index.md +++ b/src/documentation/0028-npx/index.md @@ -32,7 +32,7 @@ A typical demonstration of using `npx` is through the `cowsay` command. `cowsay` `cowsay "Hello"` will print -``` +```console _______ < Hello > ------- diff --git a/src/documentation/0055-node-inspect-object/index.md b/src/documentation/0055-node-inspect-object/index.md index 29b5e875b0..d552c755a6 100644 --- a/src/documentation/0055-node-inspect-object/index.md +++ b/src/documentation/0055-node-inspect-object/index.md @@ -19,7 +19,7 @@ We don’t have such luxury when we log something to the console, because that Now, all is fine until a certain level of nesting. After two levels of nesting, Node.js gives up and prints `[Object]` as a placeholder: -``` +```js const obj = { name: 'joe', age: 35, From dec66894cba004148738723ca7883e3028809520 Mon Sep 17 00:00:00 2001 From: Nick Schonning Date: Sat, 19 Oct 2019 12:46:36 -0400 Subject: [PATCH 6/6] fix: no-multiple-toplevel-headings --- .remarkrc | 1 - meetings/2018-10-13.md | 2 -- 2 files changed, 3 deletions(-) diff --git a/.remarkrc b/.remarkrc index 47da49805c..e846d539b1 100644 --- a/.remarkrc +++ b/.remarkrc @@ -4,7 +4,6 @@ "remark-preset-lint-node", ["remark-lint-first-heading-level", false], ["remark-lint-maximum-line-length", false], - ["remark-lint-no-multiple-toplevel-headings", false], ["remark-lint-unordered-list-marker-style", false] ] } diff --git a/meetings/2018-10-13.md b/meetings/2018-10-13.md index 651688b8e8..538a704936 100644 --- a/meetings/2018-10-13.md +++ b/meetings/2018-10-13.md @@ -4,8 +4,6 @@ * **Minutes Google Doc**: https://docs.google.com/document/d/16eRahz4dmoEBCyISoRr721Rg9gjCEXVRKVsz0RvxcUw/edit -# Collab Summit - ## Present Francisco @tolmasky