Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash of Incorrect Theme when Dark Theme is chosen #4167

Closed
U-C-S opened this issue Oct 11, 2021 · 3 comments
Closed

Flash of Incorrect Theme when Dark Theme is chosen #4167

U-C-S opened this issue Oct 11, 2021 · 3 comments

Comments

@U-C-S
Copy link

U-C-S commented Oct 11, 2021 •
edited

When reloading a page or Navigating across the site with Dark Theme on, There's a slight Flash of Light Theme.

Probably, due to HTML and CSS being loaded first and later, JavaScript code that changes the theme. To Fix it, Might want to make sure the JS code is loaded before CSS.
@U-C-S
Copy link
Author

U-C-S commented Oct 11, 2021

It can already be observed in this GIF from the Dark Mode PR: #4139 (review)

@NriotHrreion NriotHrreion mentioned this issue Oct 12, 2021
Merged
@NriotHrreion
Copy link
Contributor

I've fixed this problem and committed.

Wai-Dung pushed a commit that referenced this issue Oct 15, 2021
@NriotHrreion
Fix dark mode switcher flash bug (#4167) (#4174)
f9b2cd0 
Ref: #4167
@NriotHrreion
Copy link
Contributor

I've fixed this problem and committed.

@U-C-S: The PR has been merged.

@U-C-S U-C-S closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NriotHrreion @U-C-S