-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website testing on mobile and small screens #57
Comments
you have less than 2 days btw |
Aaaahhhhh! running around panicking Okay, well. I guess this means we'll do this after the initial release. |
@rvagg this is the biggest blocker we have right now nodejs/build#163 (comment) we need all the old node.js builds to show up in versions. |
Do we want/need to adjust the layout of the main navigation? If so, anything I can help with? I am going through and checking each page to see if any alignments are off and things like that now. |
@evanlucas Adjusting the margin/padding should be fine, ne need for a hamburger menu, et. al. |
I did some performance tests on the current https://new.nodejs.org website. WebpagetestUsing Cable connection, from Dulles. Click here for the results. Fully loaded under 1 second, Speed Index < 1000. Repeated view somewhere in the 400s. Excellent stats Using Fast 3G: Click here for the results. Fully loaded under 3 seconds, speed Index ~2500. This is okay. The repeated view is again excellent. Your cache works wonders. Using Edge: Click here for the results. Fully loaded in 16 seconds, Start render at 14 seconds. This is a bummer. Looking at the waterfall diagram (especially of the Edge render), we can easily define the culprits: Blocking CSS from three files. Solutions:
PageSpeed InsightsSolid Results for Desktop View. Again, they suggest for inlining Critical CSS and asynchronously load everything blocking. Mobile Scores are okay-ish. Ruxit Web CheckI set up a WebCheck up until launch (They are not open, but you can see what it does here). This one records availability from Chicago, Frankfurt, London, Seattle, San Jose, Boston, Paris, Atlanta, New York and Dallas, and gives an average duration time for each of those locations (measures the window.onload event with each visit). The scores are excellent there and mirror the Cable test from WebpageTest Suggestions
|
@fhemberger I can write automated tests for various cases like screen sizes, fonts etc. and performance in case you need it in future. |
Google pagespeed test: https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fnew.nodejs.org%2F |
@ddprrt Awesome, thanks Stefan! :D
So yes, a PR for unblocking Webfonts would be great. @mzgnr That sounds interesting. I'm not sure if it makes sense to invest the time into writing those test right now, as so many things are still constantly changing at the moment. But once everything has settled, they could provide insights for performance budgets. |
Are we good here or is there still only 1/5 done? |
I think there are still some CSS things left for fine-tuning. It would be nice if someone finds the time to check the site on mobile again (except for webfont issues). |
We need to test the website on small screens as well. This means browser tests (e.g. with Chrome's device mode), but also real browser tests on devices (Safari iOS, Chrome for Android, Opera Mobile).
The text was updated successfully, but these errors were encountered: