New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation of Downloads page #1550

Merged
merged 5 commits into from Feb 11, 2018

Conversation

Projects
None yet
5 participants
@oncletom
Member

oncletom commented Jan 10, 2018

Pardon my French! As part of the writing of this book, I wanted to offer the french audience a translated Downloads page 馃檪

The PR has two commits:

  1. the french translations of download/current and download pages
  2. modified partials (primary-download-matrix.hbs and secondary-download-matrics.hbs) to extract strings and make them translatable

The latter contains default strings (in English and in French) for the new translation keys.

I was a bit confused by the location of translation strings (sometimes in locale/*/site.json, sometimes directly in locale/**/*.md). I am happy to relocate them if I did not do the right move.

oncletom added some commits Jan 10, 2018

Unhardcode some strings in Downloads page
Eg: Source Code, Windows Binary etc.
@daxlab

This comment has been minimized.

Show comment
Hide comment
@daxlab

daxlab Jan 10, 2018

Member

@oncletom thanks for the effort.

Member

daxlab commented Jan 10, 2018

@oncletom thanks for the effort.

@nodejs nodejs deleted a comment from oncletom Jan 10, 2018

@Tiriel

Merci beaucoup! Thanks for the effort!
Few nits to correct, but I'll call for @nodejs/nodejs-fr to check the rest!

downloads:
headline: T茅l茅chargements
lts: LTS
current: Actuelle

This comment has been minimized.

@Tiriel

Tiriel Jan 10, 2018

Member

J'aurais plut么t dit "Courante". Plus litt茅ral mais aussi plus juste AMHA.

@Tiriel

Tiriel Jan 10, 2018

Member

J'aurais plut么t dit "Courante". Plus litt茅ral mais aussi plus juste AMHA.

lts: LTS
current: Actuelle
tagline-current: Derni猫res fonctionnalit茅s
tagline-lts: Recommand茅 pour la plupart des utilisateurs

This comment has been minimized.

@Tiriel

Tiriel Jan 10, 2018

Member

"Recommand茅e", au f茅minin plut么t, puisqu'on parle d'une version?

@Tiriel

Tiriel Jan 10, 2018

Member

"Recommand茅e", au f茅minin plut么t, puisqu'on parle d'une version?

This comment has been minimized.

@oncletom

oncletom Jan 10, 2018

Member

L脿 aussi je me suis bas茅 sur ce qu'il y avait d茅j脿 de traduit sur la page d'accueil : https://nodejs.org/fr/

@oncletom

oncletom Jan 10, 2018

Member

L脿 aussi je me suis bas茅 sur ce qu'il y avait d茅j脿 de traduit sur la page d'accueil : https://nodejs.org/fr/

This comment has been minimized.

@Tiriel

Tiriel Jan 10, 2018

Member

Au temps pour moi, on peut justifier qu'on parle d'un t茅l茅chargement!

@Tiriel

Tiriel Jan 10, 2018

Member

Au temps pour moi, on peut justifier qu'on parle d'un t茅l茅chargement!

Show outdated Hide outdated locale/fr/download/current.md Outdated
Show outdated Hide outdated locale/fr/download/current.md Outdated
Show outdated Hide outdated locale/fr/download/current.md Outdated
LinuxPowerSystems: Linux sur Power Systems
LinuxSystemZ: Linux sur System z
AIXPowerSystems: AIX sur Power Systems
---

This comment has been minimized.

@Tiriel

Tiriel Jan 10, 2018

Member

M锚mes remarques que pour le pr茅c茅dent fichier 馃檪

@Tiriel

Tiriel Jan 10, 2018

Member

M锚mes remarques que pour le pr茅c茅dent fichier 馃檪

oncletom added some commits Jan 10, 2018

Show outdated Hide outdated locale/fr/download/current.md Outdated
Show outdated Hide outdated locale/fr/download/index.md Outdated
@oncletom

This comment has been minimized.

Show comment
Hide comment
@oncletom

oncletom Jan 11, 2018

Member

Okay folks I have made changes as you spotted issues. How is it now?

Is it good enough to be merged?

Member

oncletom commented Jan 11, 2018

Okay folks I have made changes as you spotted issues. How is it now?

Is it good enough to be merged?

@fhemberger

This comment has been minimized.

Show comment
Hide comment
@fhemberger

fhemberger Jan 25, 2018

Member

/cc @nodejs/nodejs-fr @cedced19 Please do a final review, so we can merge this.

Member

fhemberger commented Jan 25, 2018

/cc @nodejs/nodejs-fr @cedced19 Please do a final review, so we can merge this.

@cedced19

This comment has been minimized.

Show comment
Hide comment
@cedced19

cedced19 Jan 25, 2018

Member

For me it's good!

Member

cedced19 commented Jan 25, 2018

For me it's good!

@fhemberger

This comment has been minimized.

Show comment
Hide comment
@fhemberger

fhemberger Feb 11, 2018

Member

Sorry, totally forgot about this. Merging now, thank you!

Member

fhemberger commented Feb 11, 2018

Sorry, totally forgot about this. Merging now, thank you!

@fhemberger fhemberger merged commit 2fe5190 into nodejs:master Feb 11, 2018

1 check passed

Travis CI via nodejs-github-bot all tests passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment