Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'copyright' and 'copyright_year.js' #2151

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
6 participants
@Maledong
Copy link
Member

commented Mar 13, 2019

Due to the discussion at nodejs/TSC#195 (comment), we
shouldn't include an auto copyright_year and its realted token place. So
we should remove it.

@Maledong Maledong requested a review from fhemberger Mar 13, 2019

@Trott
Copy link
Member

left a comment

There is no need to include the year. Please don't. It just makes for pointless annual updates that everyone forgets to do.

EDIT 1: I am not a lawyer. Expert opinion welcome, whether it be contrary to mine or not.

EDIT 2: I see this auto-updates the year. That is also problematic, I think, although less so for sure. We should not update the year for material that isn't updated. For minor updates, it should probably be a range of years rather than the latest year. Omitting the year solves the problem.

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Resulting word from the then-Executive Director of the Node.js Foundation on this topic after previous TSC conversation: nodejs/TSC#195 (comment)

Third bullet point: "Adding dates is not preferable. It does not have a legal impact and would be excluded only for ease of administration."

Our current LICENSE file says: "Copyright Node.js contributors. All rights reserved."

@Trott

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

(Although the above was about files we distribute in the source tree and not websites.)

@Maledong Maledong changed the title Fix:Add the missing copyright as the copy year Remove the 'copyright' and 'copyright_year.js' Mar 14, 2019

Remove the 'copyright' and 'copyright_year.js'
Due to the discussion at
nodejs/TSC#195 (comment), we
shouldn't include an auto copyright_year and its realted token place. So
we should remove it.

@Maledong Maledong force-pushed the Maledong:FixCopyYear branch from b3d6ba1 to d3ae5b2 Mar 14, 2019

@Maledong

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@Trott:Thanks, and it's ALWAYS you that is the FIRST to help me a lot!
Now I've removed something useless and make it suitable to the discussion.

@Trott Trott dismissed their stale review Mar 14, 2019

Seems OK to me now, although I'll definitely let fhemberger and others have the final say.

@Maledong Maledong requested a review from nodejs/website Mar 14, 2019

@ZYSzys

ZYSzys approved these changes Mar 14, 2019

Copy link
Member

left a comment

LGTM

@osk2

osk2 approved these changes Mar 14, 2019

Copy link
Member

left a comment

👍

@aymen94

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

LGTM

@marswong
Copy link
Contributor

left a comment

LGTM

@Maledong Maledong merged commit fdeaa65 into nodejs:master Mar 14, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@Maledong Maledong deleted the Maledong:FixCopyYear branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.