Skip to content

Fix generating anchors with empty IDs and links. #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix generating anchors with empty IDs and links. #2401

merged 1 commit into from
Aug 15, 2019

Conversation

@XhmikosR
Copy link
Contributor

Previously this resulted in duplicate IDs like header- and empty name attributes in translations.

@XhmikosR
Copy link
Contributor Author

Current behavior without the patch https://validator.w3.org/nu/?doc=https%3A%2F%2Fnodejs.org%2Far%2Fget-involved%2F Also the anchors are broken naturally.

@SEWeiTung SEWeiTung merged commit 410bd4c into nodejs:master Aug 15, 2019
@XhmikosR XhmikosR deleted the master-xmr-anchors branch August 15, 2019 10:06
@NOUIY NOUIY mentioned this pull request May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SEWeiTung SEWeiTung SEWeiTung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XhmikosR @SEWeiTung