New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version toggle to download page #357

Merged
merged 4 commits into from Nov 17, 2015

Conversation

Projects
None yet
7 participants
@rnsloan
Copy link
Contributor

rnsloan commented Nov 13, 2015

Fixes #321

  • Add toggle
  • remove top-right menu

1


2


3

@fhemberger

This comment has been minimized.

Copy link
Member

fhemberger commented Nov 13, 2015

Wow, awesome! 👍

@bnb

This comment has been minimized.

Copy link
Member

bnb commented Nov 13, 2015

Rally rad! 👍

@lpinca

This comment has been minimized.

Copy link
Member

lpinca commented Nov 13, 2015

It looks great.

@phillipj

This comment has been minimized.

Copy link
Member

phillipj commented Nov 13, 2015

+💯

@stevemao

This comment has been minimized.

Copy link
Member

stevemao commented Nov 14, 2015

The images look awesome :) has anyone else tested this yet?

@diagramatics

This comment has been minimized.

Copy link
Contributor

diagramatics commented Nov 14, 2015

How about a different active color for LTS and stable, just to indicate which version the user is going to download easier?

@bnb

This comment has been minimized.

Copy link
Member

bnb commented Nov 14, 2015

@diagramatics I was looking at the gif, and noticed that the Windows/OS X/Source parts have a dark gray background on hover. Maybe that could be used?

@rnsloan

This comment has been minimized.

Copy link
Contributor Author

rnsloan commented Nov 16, 2015

@bnb like this?

full

black

@bnb

This comment has been minimized.

Copy link
Member

bnb commented Nov 16, 2015

@rnsloan Yes, except keep the bright green (from the previous version) for the active state.

Notice how the gray background is only visible on hover for the Windows/Mac/Source buttons. Like that, except with the green background as an active state.

@rnsloan

This comment has been minimized.

Copy link
Contributor Author

rnsloan commented Nov 17, 2015

Colors updated. Merging.

rnsloan added a commit that referenced this pull request Nov 17, 2015

Merge pull request #357 from rnsloan/download-version-toggle
Add version toggle to download page

@rnsloan rnsloan merged commit 2b1ac04 into nodejs:master Nov 17, 2015

@phillipj

This comment has been minimized.

Copy link
Member

phillipj commented Nov 17, 2015

👯 nice work!

@bnb

This comment has been minimized.

Copy link
Member

bnb commented Nov 17, 2015

Good job. Looks awesome live!

@stevemao

This comment has been minimized.

Copy link
Member

stevemao commented Nov 17, 2015

Perfect, Thanks @rnsloan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment