Skip to content

Conversation

@AugustinMauroy
Copy link
Member

Description

Bump next.js and enabled window on ci.

Validation

I can't test locally I'm under HTPP proxy and next.js doesn't work

Related Issues

No Related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

Copilot AI review requested due to automatic review settings April 10, 2025 07:09
@AugustinMauroy AugustinMauroy requested review from a team as code owners April 10, 2025 07:09
@vercel
Copy link

vercel bot commented Apr 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2025 1:25pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • apps/site/package.json: Language not supported

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.7% (493/582) 76.03% (165/217) 86.88% (106/122)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.767s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.405s ⏱️

@avivkeller
Copy link
Member

Can you explain why turbopack doesn't work. Other than that LGTM

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 10, 2025
@ovflowd
Copy link
Member

ovflowd commented Apr 10, 2025

We can't do static exports with turbopack, will report a bug report on Vercel

@ovflowd ovflowd enabled auto-merge April 10, 2025 13:25
@ovflowd ovflowd added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 52f32bb Apr 10, 2025
14 checks passed
@ovflowd ovflowd deleted the meta-windows-next branch April 10, 2025 13:33
@bmuenzenmeyer
Copy link
Contributor

why'd we merge this so fast? I was still testing

@ovflowd
Copy link
Member

ovflowd commented Apr 11, 2025

why'd we merge this so fast? I was still testing

Upsie, my bad. Alrighty at times I forget about how long certain PRs have been around. Let's better enforce the 48 hour rules 😅

@avivkeller
Copy link
Member

avivkeller commented Apr 11, 2025

Maybe we should add a merge_group check that'll fail if a PR is too new? Edit: merge_group doesn't have access to individual PR data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants