feat(modal): re-introduce #7638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- packages/ui-components/Common/Modal/index.module.css: Language not supported
- packages/ui-components/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/ui-components/Common/Modal/index.tsx:16
- The component name 'ChangelogModal' implies a specific use case; consider renaming it to a more generic name like 'Modal' to align with the intended polyvalent usage.
const ChangelogModal: FC<ChangelogModalProps> = ({
Contributor
|
Lighthouse Results
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Contributor
Unit Test Coverage Report
|
github-actions
bot
removed
the
github_actions:pull-request
avivkeller
reviewed
Apr 10, 2025
github-actions
bot
removed
the
github_actions:pull-request
Member
|
In the storybook, shouldn't it be open by default? |
Member
Agree, It took some minutes to understand why the modal wasn't showing up xD |
Member
|
@AugustinMauroy Per the comments above, I've denied the Storybook UI tests because the tests don't accurately display the component. (https://www.chromatic.com/test?appId=64c7d71358830e9105808652&id=67f83473d3be6c83bf6f4733 is blank, because the modal is closed) |
AugustinMauroy
commented
Apr 11, 2025
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
github-actions
bot
removed
the
github_actions:pull-request
avivkeller
approved these changes
Apr 11, 2025
bjohansebas
approved these changes
Apr 11, 2025
araujogui
approved these changes
Apr 11, 2025
canerakdas
approved these changes
Apr 11, 2025
Member
canerakdas
left a comment
canerakdas
left a comment
There was a problem hiding this comment.
LGTM, apart from one nitpick, can you add the @radix-ui/react-dialog package to next.config.mjs file under optimizePackageImports 🙇
canerakdas
reviewed
Apr 11, 2025
Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio W. <cwunder@gnome.org>
ovflowd
approved these changes
Apr 11, 2025
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-introduce modal component an make it more polyvalent
Validation
Related Issues
#7445
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.