-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(dependabot): improve dependency grouping #7719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7719 +/- ##
==========================================
- Coverage 74.86% 74.84% -0.02%
==========================================
Files 98 98
Lines 7888 7888
Branches 200 200
==========================================
- Hits 5905 5904 -1
- Misses 1982 1983 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the Dependabot configuration by introducing expanded dependency grouping and updating existing update rules to prevent conflicts with ongoing Dependabot PRs.
- Added and refined dependency groups for npm.
- Updated key values and formatting for clarity.
- Modified the ignore configuration for specific dependency updates.
Files not reviewed (4)
- apps/site/package.json: Language not supported
- package.json: Language not supported
- packages/i18n/package.json: Language not supported
- packages/ui-components/package.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the grouping of dependencies managed by Dependabot. Key changes include updating the lint group's dependency patterns, adding new groups for mdx, orama, radix, and reorganizing or renaming existing groups like storybook, styling, testing, and vercel.
Files not reviewed (4)
- apps/site/package.json: Language not supported
- package.json: Language not supported
- packages/i18n/package.json: Language not supported
- packages/ui-components/package.json: Language not supported
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
OOC - Do we feel there are deps we can remove? We definitely have a good chunk of dependencies nowadays. |
|
We have a little over 110 dependencies / devDependencies1 in our project. Looking at a cursory glance of the deps, I see it: We only use We use
Footnotes
|
|
Yea, I bet we can remove some of the devDependencies even further and unify things. Also maybe some of the runtime ones 🤔 I also wish eventually for us to have incremental builds of the code itself, so that CI and Vercel doesn't need to build all other packages that did not get modified. |
|
Okay. I'm going to merge the open Dependabot PRs, rebase this, and merge. |
e08f8fa to
46e27d3
Compare
This PR adds more Dependabot groups. To prevent the existing Dependabot PRs from having issues. This also updates any dependencies that need to be updated (although, ideally, all the dependabot PRs should land first).