Skip to content

Conversation

@avivkeller
Copy link
Member

This PR adds more Dependabot groups. To prevent the existing Dependabot PRs from having issues. This also updates any dependencies that need to be updated (although, ideally, all the dependabot PRs should land first).

@vercel
Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) Visit Preview May 4, 2025 4:03pm

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.84%. Comparing base (b30c979) to head (46e27d3).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7719      +/-   ##
==========================================
- Coverage   74.86%   74.84%   -0.02%     
==========================================
  Files          98       98              
  Lines        7888     7888              
  Branches      200      200              
==========================================
- Hits         5905     5904       -1     
- Misses       1982     1983       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller marked this pull request as ready for review May 3, 2025 00:31
Copilot AI review requested due to automatic review settings May 3, 2025 00:31
@avivkeller avivkeller requested review from a team as code owners May 3, 2025 00:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the Dependabot configuration by introducing expanded dependency grouping and updating existing update rules to prevent conflicts with ongoing Dependabot PRs.

  • Added and refined dependency groups for npm.
  • Updated key values and formatting for clarity.
  • Modified the ignore configuration for specific dependency updates.
Files not reviewed (4)
  • apps/site/package.json: Language not supported
  • package.json: Language not supported
  • packages/i18n/package.json: Language not supported
  • packages/ui-components/package.json: Language not supported

@avivkeller avivkeller marked this pull request as draft May 3, 2025 01:17
@avivkeller avivkeller marked this pull request as ready for review May 3, 2025 14:03
@avivkeller avivkeller requested a review from Copilot May 3, 2025 14:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the grouping of dependencies managed by Dependabot. Key changes include updating the lint group's dependency patterns, adding new groups for mdx, orama, radix, and reorganizing or renaming existing groups like storybook, styling, testing, and vercel.

Files not reviewed (4)
  • apps/site/package.json: Language not supported
  • package.json: Language not supported
  • packages/i18n/package.json: Language not supported
  • packages/ui-components/package.json: Language not supported

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented May 3, 2025

OOC - Do we feel there are deps we can remove? We definitely have a good chunk of dependencies nowadays.

@avivkeller
Copy link
Member Author

avivkeller commented May 3, 2025

We have a little over 110 dependencies / devDependencies1 in our project. Looking at a cursory glance of the deps, I see it:

We only use acorn, remark-parse, and unified to make sure our JavaScript md snippets is parseable, however, we might be able to replace this with @eslint/markdown](https://github.com/eslint/markdown) (which supports TypeScript snippets) (I'll work on this)

We use css-loader, style-loader, and postcss-loader for Stylebook, but I wonder if there is a simpler way? Maybe one dependency?

glob can be replaced with fs, but it's experimental

Footnotes

  1. Not including dependencies of dependencies, that number is waaaay higher

@ovflowd
Copy link
Member

ovflowd commented May 3, 2025

Yea, I bet we can remove some of the devDependencies even further and unify things. Also maybe some of the runtime ones 🤔

I also wish eventually for us to have incremental builds of the code itself, so that CI and Vercel doesn't need to build all other packages that did not get modified.

@avivkeller
Copy link
Member Author

Okay. I'm going to merge the open Dependabot PRs, rebase this, and merge.

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label May 4, 2025
@avivkeller avivkeller enabled auto-merge May 4, 2025 16:03
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 4, 2025
@avivkeller avivkeller added this pull request to the merge queue May 4, 2025
Merged via the queue into main with commit a17de0b May 4, 2025
16 checks passed
@avivkeller avivkeller deleted the group-dependabot branch May 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants