Skip to content

Conversation

@avivkeller
Copy link
Member

Pin doc-kit to fix tests

Copilot AI review requested due to automatic review settings November 7, 2025 18:16
@avivkeller avivkeller requested review from a team as code owners November 7, 2025 18:16
@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 7, 2025 6:17pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @nodejs/doc-kit dependency to a specific commit hash and updates related transitive dependencies in the lockfile.

  • Pins @nodejs/doc-kit to commit be7fc307395005ea362d035c43e3818650bf075f in package.json
  • Updates transitive dependencies including @node-core/rehype-shiki (1.1.0 → 1.3.0), @node-core/ui-components (1.2.0 → 1.3.0), and shiki (3.8.1 → 3.13.0)
  • Consolidates platform-specific lightningcss binaries to version 1.30.2

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/remark-lint/package.json Pins @nodejs/doc-kit dependency to specific commit hash
pnpm-lock.yaml Updates lockfile to reflect new dependency versions and removes outdated package entries
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.76%. Comparing base (e6dd0f7) to head (5689d2b).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8340       +/-   ##
===========================================
- Coverage   90.00%   76.76%   -13.24%     
===========================================
  Files          22      118       +96     
  Lines        1590     9822     +8232     
  Branches      109      335      +226     
===========================================
+ Hits         1431     7540     +6109     
- Misses        158     2280     +2122     
- Partials        1        2        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been louder about this, but then again this long standing feature branch might not have pulled it in anyway

@bmuenzenmeyer
Copy link
Contributor

failures should be resolved within #8339

@bmuenzenmeyer bmuenzenmeyer merged commit 835090e into main Nov 7, 2025
17 of 18 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix-tests-pin branch November 7, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants