-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(pnpm): pin doc-kit #8340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pnpm): pin doc-kit #8340
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the @nodejs/doc-kit dependency to a specific commit hash and updates related transitive dependencies in the lockfile.
- Pins
@nodejs/doc-kitto commitbe7fc307395005ea362d035c43e3818650bf075fin package.json - Updates transitive dependencies including
@node-core/rehype-shiki(1.1.0 → 1.3.0),@node-core/ui-components(1.2.0 → 1.3.0), and shiki (3.8.1 → 3.13.0) - Consolidates platform-specific lightningcss binaries to version 1.30.2
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/remark-lint/package.json | Pins @nodejs/doc-kit dependency to specific commit hash |
| pnpm-lock.yaml | Updates lockfile to reflect new dependency versions and removes outdated package entries |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8340 +/- ##
===========================================
- Coverage 90.00% 76.76% -13.24%
===========================================
Files 22 118 +96
Lines 1590 9822 +8232
Branches 109 335 +226
===========================================
+ Hits 1431 7540 +6109
- Misses 158 2280 +2122
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have been louder about this, but then again this long standing feature branch might not have pulled it in anyway
|
failures should be resolved within #8339 |
Pin doc-kit to fix tests