New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add slack channel info #125

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@Eomm
Copy link
Member

Eomm commented Jan 9, 2019

Hi,
I have added to readme the slack information, referring to issue #118

Hope this help

@ljharb

ljharb approved these changes Jan 9, 2019

@mhdawson
Copy link
Member

mhdawson left a comment

LGTM, pushed a few small changes to the wording as a new commit in the PR. @Eomm as long as you are good with my changes this looks good to me.

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Jan 9, 2019

@Eomm, you might wonder why I removed "official". It's because as a partner community there is only a loose association and I want to avoid any concern over making it look like the node-js slack is more closely associated with the project than it is.

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
@Eomm

This comment has been minimized.

Copy link
Member

Eomm commented Jan 9, 2019

@mhdawson I understand what you mean and I agree with your consideration 👍

@ljharb I have applied your suggestions, thank you

@mhdawson

This comment has been minimized.

Copy link
Member

mhdawson commented Jan 10, 2019

@ljharb if you can review/approve I'll go ahead and land.

@ljharb

ljharb approved these changes Jan 10, 2019

@mhdawson mhdawson merged commit c2f28bc into nodejs:master Jan 11, 2019

@Eomm Eomm deleted the Eomm:docs/slack-channel branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment