Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing against LTS release and Current #210

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
4 participants
@Eomm
Copy link
Member

commented May 14, 2019

Closes #207

I would like to add a link to #146 or we can build a menu in the README.md

* LTS (long time support)
* Current

Of course, you are freely to maintain a package that run also with older versions of Node.js that reach the "end-of-life" stage.

This comment has been minimized.

Copy link
@ljharb

ljharb May 14, 2019

Contributor

I’d like something here that more strongly encourages testing as far back as possible, to make updating node easier for consumers, and maximize back compat.

This comment has been minimized.

Copy link
@Eomm

Eomm May 15, 2019

Author Member

In any case, consider supporting older versions of Node.js that reach the "end-of-life" stage also.
This lets your users to upgrade easily from an older version of your module to a new one.

could works this sentence?

This comment has been minimized.

Copy link
@mhdawson

mhdawson May 17, 2019

Member

Works for me.

@mhdawson
Copy link
Member

left a comment

LGTM

@ghinks ghinks merged commit 14b5f74 into master May 17, 2019

@Eomm Eomm deleted the Eomm-patch-1 branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.