Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add missing titles #290

Merged
merged 5 commits into from Dec 16, 2019
Merged

Chore: add missing titles #290

merged 5 commits into from Dec 16, 2019

Conversation

dominykas
Copy link
Member

No description provided.

dominykas and others added 2 commits November 30, 2019 20:59
Co-Authored-By: Steven <steven@ceriously.com>
Co-Authored-By: Steven <steven@ceriously.com>
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2019

@nodejs/package-maintenance more approvals would be great so we can get the 7 day clock going.

@Eomm Eomm merged commit c42f031 into nodejs:master Dec 16, 2019
@dominykas dominykas deleted the add-titles branch December 17, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants