From bd62ad2e3013b42abd7e1e392bafb7b2af9cd34f Mon Sep 17 00:00:00 2001 From: Rishabh Bhandari Date: Mon, 27 Feb 2023 16:55:18 +0530 Subject: [PATCH] moved the logic to replacements.mjs Signed-off-by: Rishabh Bhandari --- build/build.mjs | 11 ----------- build/replacements.mjs | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/build/build.mjs b/build/build.mjs index 893ab1866..f4bed1b76 100644 --- a/build/build.mjs +++ b/build/build.mjs @@ -172,17 +172,6 @@ async function main() { await rm('lib', { recursive: true, force: true }) await rm('test', { recursive: true, force: true }) - // remove obsolete methods from readable-stream - const methodNameToRemove = ['fromWeb', 'toWeb'] - const readableStreamPath = resolve(__dirname, '../lib/internal/streams/readable.js') - let readableStreamContent = await readFile(readableStreamPath, 'utf-8') - - for (const method of methodNameToRemove) { - const regex = new RegExp(`Readable.+${method} = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}`, 'g') - readableStreamContent = readableStreamContent.replace(regex, '') - writeFileSync(readableStreamPath, readableStreamContent, 'utf8') - } - // Download or open the tar file let tarFile diff --git a/build/replacements.mjs b/build/replacements.mjs index 293b4815a..5b7e75ec2 100644 --- a/build/replacements.mjs +++ b/build/replacements.mjs @@ -1,3 +1,7 @@ +import { resolve } from 'node:path' +import { writeFileSync } from 'node:fs' +import { readFile } from 'node:fs/promises' + const legacyStreamsRequireStream = ["require\\('stream'\\)", "require('./stream')"] const internalStreamsBufferPolyfill = [ @@ -152,6 +156,17 @@ const testParallelIncludeTap = [ const testParallelImportStreamInMjs = [" from 'stream';", "from '../../lib/ours/index.js';"] +export const removeObsoleteReadableMethods = async function(methodNames) { + const readableStreamPath = resolve(__dirname, '../lib/internal/streams/readable.js') + let readableStreamContent = await readFile(readableStreamPath, 'utf-8') + + for (const method of methodNames) { + const regex = new RegExp(`Readable.+${method} = function\\s\\s*\\([^)]*\\)\\s*{[^}]*}`, 'g') + readableStreamContent = readableStreamContent.replace(regex, '') + writeFileSync(readableStreamPath, readableStreamContent, 'utf8') + } +} + const testParallelImportTapInMjs = ["(from 'assert';)", "$1\nimport tap from 'tap';"] const testParallelDuplexFromBlob = [