From adb20f62c5a10adf7066ecc75f9e07ea5759dba8 Mon Sep 17 00:00:00 2001 From: Andrea Vanelli Date: Mon, 29 Aug 2022 21:27:47 +0000 Subject: [PATCH 1/2] fix: remove logical nullish assignment --- lib/fetch/headers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js index 69a3ec57576..5127e76af7c 100644 --- a/lib/fetch/headers.js +++ b/lib/fetch/headers.js @@ -402,7 +402,7 @@ class Headers { } get [kHeadersSortedMap] () { - this[kHeadersList][kHeadersSortedMap] ??= new Map([...this[kHeadersList]].sort((a, b) => a[0] < b[0] ? -1 : 1)) + this[kHeadersList][kHeadersSortedMap] ?? (this[kHeadersList][kHeadersSortedMap] = new Map([...this[kHeadersList]].sort((a, b) => a[0] < b[0] ? -1 : 1))) return this[kHeadersList][kHeadersSortedMap] } From 105f75e68c78012afafbba593fc1486883f4ecf4 Mon Sep 17 00:00:00 2001 From: Andrea Vanelli Date: Tue, 30 Aug 2022 16:50:13 +0000 Subject: [PATCH 2/2] more readable code --- lib/fetch/headers.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js index 5127e76af7c..78f2990774f 100644 --- a/lib/fetch/headers.js +++ b/lib/fetch/headers.js @@ -402,7 +402,9 @@ class Headers { } get [kHeadersSortedMap] () { - this[kHeadersList][kHeadersSortedMap] ?? (this[kHeadersList][kHeadersSortedMap] = new Map([...this[kHeadersList]].sort((a, b) => a[0] < b[0] ? -1 : 1))) + if (!this[kHeadersList][kHeadersSortedMap]) { + this[kHeadersList][kHeadersSortedMap] = new Map([...this[kHeadersList]].sort((a, b) => a[0] < b[0] ? -1 : 1)) + } return this[kHeadersList][kHeadersSortedMap] }