From 0906765a1488cc9d31a47da471f4aa55d55b6c13 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Wed, 24 Apr 2024 06:04:14 +0900 Subject: [PATCH 1/4] test: add headerslist copy check --- test/fetch/request.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/fetch/request.js b/test/fetch/request.js index f02fd2405e5..1b4f231a5e3 100644 --- a/test/fetch/request.js +++ b/test/fetch/request.js @@ -465,12 +465,13 @@ test('request.referrer', () => { // https://github.com/nodejs/undici/issues/2445 test('Clone the set-cookie header when Request is passed as the first parameter and no header is passed.', (t) => { - const { strictEqual } = tspl(t, { plan: 2 }) const request = new Request('http://localhost', { headers: { 'set-cookie': 'A' } }) const request2 = new Request(request) + assert.strictDeepEqual([...request.headers], [['set-cookie', 'A']]) request2.headers.append('set-cookie', 'B') - strictEqual(request.headers.getSetCookie().join(', '), request.headers.get('set-cookie')) - strictEqual(request2.headers.getSetCookie().join(', '), request2.headers.get('set-cookie')) + assert.strictDeepEqual([...request.headers], [['set-cookie', 'A']]) + assert.strictEqual(request.headers.getSetCookie().join(', '), request.headers.get('set-cookie')) + assert.strictEqual(request2.headers.getSetCookie().join(', '), request2.headers.get('set-cookie')) }) // Tests for optimization introduced in https://github.com/nodejs/undici/pull/2456 From 2d2e2d244b34b9c46cf2179962880497c7d373c8 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Wed, 24 Apr 2024 06:10:14 +0900 Subject: [PATCH 2/4] Apply suggestions from code review --- test/fetch/request.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/fetch/request.js b/test/fetch/request.js index 1b4f231a5e3..b41d35f6da4 100644 --- a/test/fetch/request.js +++ b/test/fetch/request.js @@ -467,9 +467,9 @@ test('request.referrer', () => { test('Clone the set-cookie header when Request is passed as the first parameter and no header is passed.', (t) => { const request = new Request('http://localhost', { headers: { 'set-cookie': 'A' } }) const request2 = new Request(request) - assert.strictDeepEqual([...request.headers], [['set-cookie', 'A']]) + assert.deepStrictEqual([...request.headers], [['set-cookie', 'A']]) request2.headers.append('set-cookie', 'B') - assert.strictDeepEqual([...request.headers], [['set-cookie', 'A']]) + assert.deepStrictEqual([...request.headers], [['set-cookie', 'A']]) assert.strictEqual(request.headers.getSetCookie().join(', '), request.headers.get('set-cookie')) assert.strictEqual(request2.headers.getSetCookie().join(', '), request2.headers.get('set-cookie')) }) From 87abe38bd3a6a33878132978919a419f56289a92 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Wed, 24 Apr 2024 12:52:52 +0900 Subject: [PATCH 3/4] Update request.js --- test/fetch/request.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/fetch/request.js b/test/fetch/request.js index b41d35f6da4..1423bd3f166 100644 --- a/test/fetch/request.js +++ b/test/fetch/request.js @@ -449,7 +449,8 @@ test('set-cookie headers get cleared when passing a Request as first param', () assert.deepStrictEqual([...req1.headers], [['set-cookie', 'a=1']]) const req2 = new Request(req1, { headers: {} }) - + assert.deepStrictEqual([...req1.headers], [['set-cookie', 'a=1']]) + assert.deepStrictEqual([...req2.headers], []) assert.deepStrictEqual(req2.headers.getSetCookie(), []) }) From a7c021f6ba145701c435966108f1ee7292bedf04 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Wed, 24 Apr 2024 12:58:13 +0900 Subject: [PATCH 4/4] Update test/fetch/request.js --- test/fetch/request.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/fetch/request.js b/test/fetch/request.js index 1423bd3f166..4e007da2b19 100644 --- a/test/fetch/request.js +++ b/test/fetch/request.js @@ -450,7 +450,6 @@ test('set-cookie headers get cleared when passing a Request as first param', () assert.deepStrictEqual([...req1.headers], [['set-cookie', 'a=1']]) const req2 = new Request(req1, { headers: {} }) assert.deepStrictEqual([...req1.headers], [['set-cookie', 'a=1']]) - assert.deepStrictEqual([...req2.headers], []) assert.deepStrictEqual(req2.headers.getSetCookie(), []) })