Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build cleanup #648

Merged
merged 3 commits into from Apr 2, 2021
Merged

Docker build cleanup #648

merged 3 commits into from Apr 2, 2021

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 31, 2021

Remove .dokerignore file and use consistent naming in npm scripts.

Fixes #638 .

@dnlup
Copy link
Contributor Author

dnlup commented Mar 31, 2021

I think the main drawback we have here js that now we are sending the whole root dir as a context before building the image:

@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #648 (75d52b9) into main (c021f8b) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
+ Coverage   97.50%   97.56%   +0.05%     
==========================================
  Files          18       18              
  Lines        1685     1685              
==========================================
+ Hits         1643     1644       +1     
+ Misses         42       41       -1     
Impacted Files Coverage Δ
lib/llhttp/parser.js 93.05% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c021f8b...75d52b9. Read the comment docs.

@ronag
Copy link
Member

ronag commented Mar 31, 2021

I think the main drawback we have here js that now we are sending the whole root dir as a context before building the image:

Good point. Maybe do both then? COPY and dockerignore?

@dnlup
Copy link
Contributor Author

dnlup commented Mar 31, 2021

I think the main drawback we have here js that now we are sending the whole root dir as a context before building the image:

Good point. Maybe do both then? COPY and dockerignore?

Yes. Just to be sure, we still won't COPY . . but each asset needed individually, right?

.husky
examples
benchmarks
# Ignore everything but the stuff following the `*` with the `!`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for a "exclude everything" by default. It keeps the list shorter.

"prebuild-wasm": "docker build -t llhttp_wasm_builder -f build/Dockerfile .",
"build-wasm": "node build/wasm.js --docker",
"prebuild:wasm": "docker build -t llhttp_wasm_builder -f build/Dockerfile .",
"build:wasm": "node build/wasm.js --docker",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of renaming the scripts to make them more consistent.

@ronag ronag requested a review from mcollina April 2, 2021 11:04
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6f073d3 into main Apr 2, 2021
@dnlup dnlup deleted the build_docker_cleanup branch April 2, 2021 13:15
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't copy entire root when building Docker
5 participants