Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial RSA prototype #4

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@tniessen
Copy link
Member

commented Aug 10, 2019

This adds basic support for RSASSA-PKCS1-v1_5 (section 20) and RSA-PSS (section 21). Like all the other code, it is just a prototype, and will need a lot of refining, but most things should work.

Fixes: #2
Fixes: #3

@tniessen tniessen requested a review from sam-github Aug 12, 2019

Show resolved Hide resolved lib/algorithms/rsa.js
Show resolved Hide resolved lib/algorithms/rsa.js
@sam-github
Copy link
Member

left a comment

If you aren't going to throw an op-error, then add an assert on the expected input lenght. Other than that, RSLGTM.

@tniessen tniessen force-pushed the tniessen:add-rsa-prototype branch from 82cdf48 to e92037d Aug 12, 2019

@tniessen tniessen merged commit d38cd25 into nodejs:master Aug 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@tniessen tniessen deleted the tniessen:add-rsa-prototype branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.