Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add rfc5869 HKDF test vectors #46

Open
wants to merge 1 commit into
base: master
from

Conversation

@panva
Copy link
Contributor

panva commented Mar 25, 2020

This adds the test vectors from https://tools.ietf.org/html/rfc5869#appendix-A to the unit test suite.

Copy link
Member

tniessen left a comment

In general, I don't want to add too many test vectors for things that are covered by Node.js tests and web-platform-tests, but since HKDF does not exist in Node.js, this makes sense. Thanks!

test/unit/algorithms/hkdf.js Outdated Show resolved Hide resolved
@panva

This comment has been minimized.

Copy link
Contributor Author

panva commented Mar 25, 2020

but since HKDF does not exist in Node.js

something to think of ;)

@panva panva force-pushed the panva:hkdf-test-vectors branch from 353cc7e to 7397100 Mar 27, 2020
@panva panva force-pushed the panva:hkdf-test-vectors branch from 7397100 to 0dac11b Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.