Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage script #9

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@tniessen
Copy link
Member

commented Aug 10, 2019

Add coverage using Istanbul.

@tniessen tniessen force-pushed the tniessen:add-coverage branch from 1b71ab4 to f250fb3 Aug 10, 2019

@tniessen tniessen requested a review from sam-github Aug 12, 2019

@panva

This comment has been minimized.

Copy link

commented Aug 12, 2019

Have you considered c8 (uses the native NODE_V8_COVERAGE)?

Especially for a node project i think it's a nice way of applying Eat Your Own Dog Food.

@tniessen

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

I don't have a strong opinion regarding which tool to use. I only used nyc until now and as far as I know, it is still the most popular coverage tool for node packages. I think how the data is gathered is an implementation detail, and c8 still uses Istanbul for reports, so I don't think it makes much of a difference.

@tniessen tniessen merged commit b17bcb6 into nodejs:master Aug 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.