Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with a note about Windows Subsystem for Linux #106

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@jchiatt
Copy link
Contributor

jchiatt commented Jul 21, 2018

No description provided.

@jasonkarns

This comment has been minimized.

Copy link
Member

jasonkarns commented Nov 8, 2018

Does WSL not use bash shell by default?

@jchiatt

This comment has been minimized.

Copy link
Contributor Author

jchiatt commented Nov 9, 2018

@jasonkarns I believe it does, but for some reason it prioritized .profile over .bash_profile

@jasonkarns

This comment has been minimized.

Copy link
Member

jasonkarns commented Nov 9, 2018

Did it prioritize .profile or just fall back to it? Bash will fallback to .profile if .bash_profile doesn't exist, but it should prefer .bash_profile. Unless WSL bash is doing something nonstandard, I would prefer to not recommend using .profile because that file is meant to be shell agnostic. (Other shells can and may read that file.)

Can you confirm that .profile is read by WSL even when .bash_profile exists?
And also confirm whether .bash_profile is read when they both exist? (It may be the case that some other file is causing .profile to be sourced, and that it's not strictly bash doing so as part of its startup. Perhaps an /etc/profile or other file is triggering the sourcing of ~/.profile)

https://linux.die.net/Bash-Beginners-Guide/sect_03_01.html

@jasonkarns

This comment has been minimized.

Copy link
Member

jasonkarns commented Nov 9, 2018

You can scratch the above requests. I see now that Ubuntu is recommending alternative practices and since WSL uses Ubuntu, that would follow the same there.

Which means we probably just want to add WSL to the existing Ubuntu recommendation.

@jasonkarns

This comment has been minimized.

Copy link
Member

jasonkarns commented Nov 9, 2018

Sorry I keep piling on 😸

See the related change in rbenv for the rationale around using .bashrc instead of .profile.

Would you mind updating this PR to just include WSL (perhaps unabbreviated? 🤷‍♂️ ) along with the existing Ubuntu option? And reference the above commit in your commit message, so the rationale is documented? Thanks!

(And rbenv would probably be glad for the same change upstream)

@jasonkarns jasonkarns merged commit f4fbdb6 into nodenv:master Jan 3, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
security/snyk - package.json (nodenv) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.