fix: Remove erroneously added non-specced spaces #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we add spaces to cloze and comprehension exercises without checking the relevant flags in the spec, we always add spaces between words indiscriminately. The presentation of text should instead add spaces only when specified. This commit will: - update the exercise generator to actually pass the inject spaces-flag on to the renderer - update the renderer to more robustly present spaces **Certification** - [X] I certify that <!-- Check the box to certify: [X] --> - I have read the [contributing guidelines]( https://github.com/nodepa/seedlingo/blob/main/.github/CONTRIBUTING.md) - I license these contributions to the public under Seedlingo's [LICENSE](https://github.com/nodepa/seedlingo/blob/main/LICENSE.md) and have the rights to do so. Signed-off-by: toshify <4579559+toshify@users.noreply.github.com>
toshify
force-pushed
the
fix/remove-erroneous-spaces
branch
from
f912354
to
2d84013
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we add spaces to cloze and comprehension exercises without checking the relevant flags in the spec,
we always add spaces between words indiscriminately. The presentation of text should instead add spaces only when specified.
This commit will:
Certification