dockerfile: no longer require package-lock #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethGriggs
commented
Mar 21, 2023
Comment on lines
+4
to
+5
| # Copy package.json, and optionally package-lock.json if it exists | ||
| COPY package.json package-lock.json* ./ |
There was a problem hiding this comment.
The final npm start command in the Dockerfile relies on a package.json existing. This copy command means we fail early if it doesn't.
There was a problem hiding this comment.
I assume the * at the end is what gets us the does not fail if package-lock.json does not exist but it would copy over package-lock.json2 etc. as well. We might be able to tighten that up but I don't think that is a blocker for this PR.
BethGriggs
commented
Mar 21, 2023
Comment on lines
+8
to
+11
| RUN \ | ||
| if [ -f package-lock.json ]; then npm ci; \ | ||
| else npm install; \ | ||
| fi |
There was a problem hiding this comment.
Fallback in case of no package-lock.json. It's unusual for a Node.js project repository to not have one these days, but let's cater for the exception.
richardlau
approved these changes
Mar 21, 2023
maysunfaisal
approved these changes
Mar 21, 2023
Roming22
added a commit
to Roming22/devfile-sample-nodejs
that referenced
this pull request
Apr 10, 2023
dockerfile: no longer require package-lock (nodeshift-starters#29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the DevFile to work for as many applications as possible out of the box, so this adds a fallback for the case a project does not have a
package-lock.json