Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb: install gnupg package if it's not there #758

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@rvagg
Copy link
Contributor

rvagg commented Nov 21, 2018

Debian slim docker images have apt-key but not gnupg so apt-key add fails

Originally reported @ nodejs/nodejs.org#1905, the php:7 which builds on debian:stretch-slim fails the install script because there's no gnupg. On Ubuntu it comes from apt-add-key which depends on both apt (which has apt-key) and gnupg which is installed on Ubuntu by default I think. On non-slim Debian images it's there too as a default package, but it was stripped out by slim and apt-key is there but I guess apt-key add isn't intended to work out of the box.

@chrislea over to you

deb: install gnupg package if it's not there
debian slim docker images have `apt-key` but not `gnupg` so `apt-key add` fails
@gengjiawen

This comment has been minimized.

Copy link
Contributor

gengjiawen commented Dec 15, 2018

I think this related to #771.

@gengjiawen

This comment has been minimized.

Copy link
Contributor

gengjiawen commented Dec 16, 2018

Also do you think adding CI to this project is necessary ? we can test all major linux distro using docker in circle ci.

@rvagg rvagg referenced this pull request Mar 11, 2019

Merged

add ci #781

@gkrizek gkrizek merged commit aefa883 into master Mar 18, 2019

@gkrizek

This comment has been minimized.

Copy link
Member

gkrizek commented Mar 18, 2019

@rvagg @gengjiawen, This has been merged and the files have been updated on our origin servers. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.