Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work with facebook/react #115

Closed
juliangruber opened this Issue Mar 13, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@juliangruber
Copy link
Member

juliangruber commented Mar 13, 2019

$ goto facebook react
$ ncm report

╔══════════════╗
║ react Report ║
╚══════════════╝

‼︎ Unable to fetch project report. Have you run `ncm signin`?

I am signed in, so there must be something else going on. This was before I ran yarn, so while there's no node_modules/ there's a package.json and a yarn.lock, which should be all this tool needs.

@juliangruber

This comment has been minimized.

Copy link
Member Author

juliangruber commented Mar 13, 2019

Same error after installing the dependencies.

@juliangruber

This comment has been minimized.

Copy link
Member Author

juliangruber commented Mar 13, 2019

Is there a way to get more error output? I think @Raynos was wanting this too.

@Raynos

This comment has been minimized.

Copy link
Contributor

Raynos commented Mar 13, 2019

i added a functionality and it surfaced a message for this previously which was cannot find node_modules or something; there's a NCM_DEV=1 flag i think that should add that back ?

But yeah error reporting is a little opague.

@juliangruber

This comment has been minimized.

Copy link
Member Author

juliangruber commented Mar 13, 2019

No change with NCM_DEV=1. And the underlying module universal-module-tree works without node_modules too, as long as there's a lock file.

@pmuellr

This comment has been minimized.

Copy link

pmuellr commented Mar 13, 2019

I think it's this line:

https://github.com/facebook/react/blob/9d77a317bf5bde7e6edd3c8cd0ebb00feb447223/package.json#L54

    "eslint-plugin-react-internal": "link:./scripts/eslint-rules/",

I noticed npm install complained about this, so I just removed it and ran ncm-cli again and it worked fine.

@juliangruber

This comment has been minimized.

Copy link
Member Author

juliangruber commented Mar 14, 2019

right! so in that case universal-module-tree could only look at node_modules/. I'll work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.