Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make `report` the default command. closes #114 #146

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@juliangruber
Copy link
Member

commented May 3, 2019

Now verifying projects is even easier.

To verify the current project, just run

$ ncm

To verify a different project, run

$ ncm ../dir

@juliangruber juliangruber requested review from Raynos and Fishrock123 May 3, 2019

subargs.unshift(command)
command = 'report'
} catch (_) {
command = 'help'

This comment has been minimized.

Copy link
@Fishrock123

Fishrock123 May 6, 2019

Contributor

The report command's internals should be the one handling this.

Also:

const { stat } = require('fs')
const { promisify } = require('util')
const statP = promisify(stat)

// ...

await stat(...)

This comment has been minimized.

Copy link
@juliangruber

juliangruber May 7, 2019

Author Member

The report command's internals should be the one handling this.

Which part? As far as I understand this logic, then report would be required to run the help command, if that stat fails. And it's cleaner if commands don't run each other I think.

Also:

What's the advantage of using async over sync fs calls in a CLI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.