Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http(s) proxy support #147

Merged
merged 3 commits into from May 9, 2019

Conversation

Projects
None yet
3 participants
@Fishrock123
Copy link
Contributor

commented May 6, 2019

Implements #142 for environment variables by way of proxy-from-env and a proxy-agent http.Agent overload.

@Fishrock123 Fishrock123 requested a review from Raynos May 6, 2019

http_proxy: `http://localhost:${procPort}`
})
} catch (err) {
const { stdout, stderr } = err

This comment has been minimized.

Copy link
@Fishrock123

Fishrock123 May 6, 2019

Author Contributor

Since this command results in a non-zero exit code, this is how it needs to be handled with await.

Fishrock123 added some commits May 3, 2019

util,deps: remove graphql-request
graphql-request was completely unecessary and removing it actually results in less code and duplication.

This also paves the way for us to overload the `http.Agent` easier for proxing via an agent overload.

PR-URL: #147
test-runner: use execPath, this.env, cli launch
Several reliability and usability improvements:

- use execPath and do not assume the "node" binary.
- this.env ensures consitency and also allows env access from tests
- the cli testser makes doing some test development easier.

PR-URL: #147
client-request: http(s)_proxy support
Adds support for http(s) proxies via our client-request wrapper when specified by environment variables.

Supports anything that both proxy-from-env and proxy-agent accept.
That includes all variations of http_proxy and https_proxy.

Closes #142
PR-URL: #147

@Fishrock123 Fishrock123 force-pushed the fishrock/request-proxy branch from b5b19e9 to 957c27c May 6, 2019

@Fishrock123

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@Raynos (idk if you get the review requests haha)

@Fishrock123 Fishrock123 merged commit 957c27c into master May 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Jazneil Jazneil added this to the Sprint 13 (4/30 - 5/20) milestone May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.