Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update nodejs versions in travis #169

Merged
merged 1 commit into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@Fishrock123
Copy link
Contributor

commented Jul 4, 2019

12 has been stable a couple months, 13 is master.

@Fishrock123 Fishrock123 requested a review from Raynos Jul 4, 2019

@Raynos

Raynos approved these changes Jul 4, 2019

@Fishrock123

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Fwiw, Node 13 fails (but is ignored):

> npm run -s test-only
/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:1
TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
    at /home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:47:23
    at Object.<anonymous> (/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:181:3)
/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:1
TypeError: Function.prototype.apply was called on undefined, which is a undefined and not a function
    at /home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:47:23
    at Object.<anonymous> (/home/travis/.node-spawn-wrap-4587-6402d56cf63e/node:181:3)
test/details.js ....................................... 0/1
  not ok test/details.js

This is currently a known issue, filed to nodejs/node#28294, originating from standard-things/esm#821.

ci: update nodejs versions in travis
12 has been stable a couple months, 13 is master.

PR-URL: #169

@Fishrock123 Fishrock123 force-pushed the fishrock/update-ci-nodejs branch from 6323dc2 to 32ba612 Jul 4, 2019

@Fishrock123 Fishrock123 merged commit 32ba612 into master Jul 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Fishrock123 Fishrock123 deleted the fishrock/update-ci-nodejs branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.