Skip to content


Subversion checkout URL

You can clone with
Download ZIP


honor system proxy #4

merged 1 commit into from

2 participants


Please, consider applying


Have you tested this when no ENV['http_proxy'] is set? I think in current form it will crash on undefined.

Can you wrap it in a test for it being set, if not then don't set proxy.


This is not needed. In case you mention the net result is passing proxy: undefined, which is effectively the same as not specifying proxy key at all.

I have tested, and it works ok.


Ah, doh. ok :)

@DanBUK DanBUK merged commit 657bf64 into nodester:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 20, 2011
  1. @dvv

    honor system proxy

    dvv committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +2 −1  nodester.js
3  nodester.js
@@ -50,7 +50,8 @@ nodester.prototype.request = function(method, path, body, cb) {
uri: this.baseurl + path,
method: method,
body: querystring.stringify(body),
- headers: headers
+ headers: headers,
+ proxy: process.env.http_proxy
Something went wrong with that request. Please try again.