honor system proxy #4

Merged
merged 1 commit into from Jul 20, 2011

Conversation

Projects
None yet
2 participants
Contributor

dvv commented Jul 20, 2011

Please, consider applying

Contributor

DanBUK commented Jul 20, 2011

Have you tested this when no ENV['http_proxy'] is set? I think in current form it will crash on undefined.

Can you wrap it in a test for it being set, if not then don't set proxy.

Contributor

dvv commented Jul 20, 2011

This is not needed. In case you mention the net result is passing proxy: undefined, which is effectively the same as not specifying proxy key at all.

I have tested, and it works ok.

Contributor

DanBUK commented Jul 20, 2011

Ah, doh. ok :)

DanBUK merged commit 657bf64 into nodester:master Jul 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment