Skip to content
This repository

Possibly unnecessary username check #401

Closed
Tenzer opened this Issue · 3 comments

3 participants

Jeppe Toustrup Alejandro Morales Nodester
Jeppe Toustrup

While looking through the code, I came to wonder why there is a check for the validity of a username at this location:
https://github.com/nodester/nodester/blob/master/lib/user.js#L72-77

It would make better sense to put further up in the code base, by which all methods may take benefit from it. I have however not made a pull request to change this, in case I have misunderstood the code.

Alejandro Morales
Collaborator

Hmm I think you are right! @chrismatthieu what do you think about it?

Nodester
Owner
Jeppe Toustrup

I have made a pull request to remove the check at #402.

Jeppe Toustrup Tenzer closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.