Possibly unnecessary username check #401

Closed
Tenzer opened this Issue Aug 17, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

Tenzer commented Aug 17, 2012

While looking through the code, I came to wonder why there is a check for the validity of a username at this location:
https://github.com/nodester/nodester/blob/master/lib/user.js#L72-77

It would make better sense to put further up in the code base, by which all methods may take benefit from it. I have however not made a pull request to change this, in case I have misunderstood the code.

Collaborator

alejandro commented Aug 17, 2012

Hmm I think you are right! @chrismatthieu what do you think about it?

Owner

nodester commented Aug 17, 2012

Yep, I say we go for it.

Sent from my iPhone

On Aug 17, 2012, at 3:08 PM, alejandromg notifications@github.com wrote:

Hmm I think you are right! @chrismatthieu what do you think about it?


Reply to this email directly or view it on GitHub.

Contributor

Tenzer commented Aug 18, 2012

I have made a pull request to remove the check at #402.

@Tenzer Tenzer closed this Aug 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment