Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use PORT instead of app_port #408

Closed
jmendeth opened this Issue Nov 20, 2012 · 6 comments

Comments

Projects
None yet
3 participants

It's better to use the PORT environment variable than app_port.
Simpler, standard and upper-case.
In fact, the following PaaS already use PORT:

  • Nodejitsu
  • Cloud9
  • Heroku

I know it's already supported, now it's better
to recommend the use of PORT and deprecate app_port
in the help pages.

Collaborator

alejandro commented Nov 20, 2012

Yeah! I've thought about this for a long time. But not sure right now
because of the nodester status. @chrismatthieu what do you think?

2012/11/20 Xavier Mendez notifications@github.com

It's better to use the PORT environment variable than app_port.
Simpler, standard and upper-case.
In fact, the following PaaS already use PORT:

  • Nodejitsu
  • Cloud9
  • Heroku

I know it's already supported, now it's better
to recommend the use of PORT and deprecate app_port
in the help pages.


Reply to this email directly or view it on GitHubhttps://github.com/nodester/nodester/issues/408.

Atentamente
Víctor Alejandro Morales Gámez
*
*
*
*

Collaborator

chrismatthieu commented Nov 20, 2012

I like the idea of using port too. Hopefully this will make it easier to move from external services to Nodester.

Collaborator

alejandro commented Nov 20, 2012

@jmendeth done! You can use "PORT" instead of "app_port" now. Hack the Planet \m/

@alejandro alejandro closed this Nov 20, 2012

@alejandro Great, thanks! Now it would be great to favour its use and deprecate app_port in the help pages.

@chrismatthieu
Not only that, Nodester is now compatible with the [also open-source] Cloud9 IDE!
I can see if I can work on a way to deploy from C9 -> Nodester.

Yeah, I master both APIs. 😎
By the way, the image in the article is broken.

@gkoberger gkoberger added a commit to hookapi/hook-server that referenced this issue Jun 18, 2013

@alejandro @gkoberger alejandro + gkoberger Add support to "PORT" instead of app_port. #408 e77f22c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment