Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid requests to external resources from tests #100

Open
kaero opened this issue Dec 8, 2014 · 4 comments
Open

Avoid requests to external resources from tests #100

kaero opened this issue Dec 8, 2014 · 4 comments
Labels
test

Comments

@kaero
Copy link
Contributor

kaero commented Dec 8, 2014

https://travis-ci.org/nodules/asker/builds/43318134
https://travis-ci.org/nodules/asker/builds/43318136
@kaero kaero changed the title Scoket timeout and binary encoder tests sometimes fails. Socket timeout and binary encoder tests sometimes fails. Dec 8, 2014
narqo pushed a commit that referenced this issue Nov 10, 2015
Merge pull request #112 from /issues/100
ef7579a 
Fix tests for body encoder "multipart"
@narqo
Copy link

narqo commented Nov 10, 2015

Encoders part was fixed with #112.

This was referenced Nov 10, 2015
Merged
Closed
@kaero
Copy link
Contributor Author

kaero commented Feb 26, 2016

@narqo had you observe flaky results of tests in last time?

@kaero kaero closed this as completed Feb 26, 2016
@kaero kaero reopened this Feb 26, 2016
@kaero
Copy link
Contributor Author

kaero commented Mar 8, 2016

@narqo ping

@narqo
Copy link

narqo commented Mar 8, 2016

No, but as we request an external resources in our https tests (e.g. https://yandex.com), I don't see a reason it to stay 100% stable.

@kaero kaero changed the title Socket timeout and binary encoder tests sometimes fails. Avoid requests to external resources from tests Mar 8, 2016
@kaero kaero removed the bug label Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@narqo @kaero