Add SSL Support #11

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
3 participants
@rhalff

rhalff commented Jan 3, 2015

This pull request adds ssl support.

The certificate is expected to be present in the ./ssl directory.

To switch to secure mode an --secure option is added.

@rhalff rhalff referenced this pull request in noflo/noflo-ui Jan 3, 2015

Closed

offer https #402

@forresto forresto referenced this pull request in noflo/noflo-ui Jan 30, 2015

Open

Can't use a runtime in HTTPS mode #433

@jonnor

This comment has been minimized.

Show comment
Hide comment
@jonnor

jonnor Mar 26, 2015

Member

Hi, thanks for this pull request.
Is there a particular reason why SSL certs are not looked up in the standard places provided by the operating system?

Member

jonnor commented Mar 26, 2015

Hi, thanks for this pull request.
Is there a particular reason why SSL certs are not looked up in the standard places provided by the operating system?

@rhalff

This comment has been minimized.

Show comment
Hide comment
@rhalff

rhalff Mar 26, 2015

Yeah that would probably be better, I notice I've hardcoded the (odd) location.

I'm not sure what are all the common locations though.

Adding a --ssl-key and a --ssl-cert option would probably be the most flexible solution?

If those are required it makes the --secure option redundant.

rhalff commented Mar 26, 2015

Yeah that would probably be better, I notice I've hardcoded the (odd) location.

I'm not sure what are all the common locations though.

Adding a --ssl-key and a --ssl-cert option would probably be the most flexible solution?

If those are required it makes the --secure option redundant.

@ensonic

This comment has been minimized.

Show comment
Hide comment
@ensonic

ensonic Mar 27, 2015

Contributor

rhalff, I just noticed that my work today created quite some havoc for your PR. Apologies. Can you recover your working code using http://js2.coffee/ and then generate a new patch from that?

Contributor

ensonic commented Mar 27, 2015

rhalff, I just noticed that my work today created quite some havoc for your PR. Apologies. Can you recover your working code using http://js2.coffee/ and then generate a new patch from that?

@rhalff rhalff closed this Apr 13, 2015

@jonnor jonnor referenced this pull request Feb 15, 2016

Closed

SSL support #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment