Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL Support #11

Closed
wants to merge 9 commits into from
Closed

Add SSL Support #11

wants to merge 9 commits into from

Conversation

@rhalff
Copy link

rhalff commented Jan 3, 2015

This pull request adds ssl support.

The certificate is expected to be present in the ./ssl directory.

To switch to secure mode an --secure option is added.

@jonnor
Copy link
Member

jonnor commented Mar 26, 2015

Hi, thanks for this pull request.
Is there a particular reason why SSL certs are not looked up in the standard places provided by the operating system?

@rhalff
Copy link
Author

rhalff commented Mar 26, 2015

Yeah that would probably be better, I notice I've hardcoded the (odd) location.

I'm not sure what are all the common locations though.

Adding a --ssl-key and a --ssl-cert option would probably be the most flexible solution?

If those are required it makes the --secure option redundant.

@ensonic
Copy link
Contributor

ensonic commented Mar 27, 2015

rhalff, I just noticed that my work today created quite some havoc for your PR. Apologies. Can you recover your working code using http://js2.coffee/ and then generate a new patch from that?

@rhalff rhalff closed this Apr 13, 2015
@jonnor jonnor mentioned this pull request Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.