Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Windows path resolution issues in ComponentLoader #111

Closed
bergie opened this Issue · 7 comments

3 participants

@bergie
Owner

It seems ComponentLoader fails to resolve component and graph paths on Windows, and so loading them doesn't work.

We should probably ensure we replace all slashes (/) with path.sep in ComponentLoader

Some related links:

@p0wl

As stated in Google Groups (https://groups.google.com/forum/#!topic/flow-based-programming/v7Wiiyys-Ik ): I'm willing to help but unable to run the tests as https://github.com/jdcataldo/grunt-mocha-phantomjs cannot be installed on windows.

I'm going to try to fix the paths, but I'm not as familiar as I should be with the noflo internals and coffeescript to be sure that I got it right.

I would be very thankful if someone with more expertise could replace the the slashes as @bergie suggested. I can verify if it works on windows if someone sends a PR.

@bergie
Owner

@p0wl ok, just comment out the phantomjs dependency on package.json and the Gruntfile.coffee

@bergie
Owner

We should note that this includes other subtle path issues, like #122

@bergie
Owner

Doesn't seem to be a problem any longer. I just verified by running tests of a rather large NoFlo app on Node.js/Win8

@bergie bergie closed this
@Bartvds

FYI: If you need Windows based node.js CI testing there is now http://www.appveyor.com, it is very similar to Travis-CI except it is focussed on Microsoft platforms (but with node and github and a nice .yml setup etc).

@bergie
Owner

@Bartvds thanks! Added

@bergie
Owner

Seems path resolution is fine: these tests actually run a graph that depends on components from other libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.