Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressable port in WirePattern behaves incorrectly when receiving IP from another component #252

Closed
paulyoung opened this issue Aug 6, 2014 · 7 comments

Comments

@paulyoung
Copy link
Contributor

The issue I'm seeing as that a packet sent from a component isn't being converted into an object with array indexes as keys.

I have a component which sends a string from its NAME out port to an addressable port on another component like so:

Create(CreateTask) NAME -> TASKS[0] List(ListTasks)

Here, data.tasks is My task in the WirePattern proc function.

However, passing a string identical to the one sent above produces the expected result:

'My task' -> TASKS[0] List(ListTasks)

data.tasks is { '0': 'My task' }

My tests for this component pass but they only send IIPs. I only saw the issue when sending an IP from another component when running a graph.

@trustmaster
Copy link
Member

I haven't tested it with output from a component either, so it could be a bug indeed. Theoretically there should be no difference between an IIP and a normal IP.

@paulyoung paulyoung changed the title Addressable port in WirePattern behaves incorrectly when running in graph Addressable port in WirePattern behaves incorrectly when receiving IP from another component Aug 6, 2014
trustmaster added a commit to trustmaster/noflo that referenced this issue Aug 8, 2014
@trustmaster
Copy link
Member

I've added a test for this in Helpers spec (see link above) but it passes. Seems like it's something with the FBP parser or addressable ports in Networks.

@paulyoung
Copy link
Contributor Author

Let me know if there's anything else I can do to help.

@trustmaster
Copy link
Member

@paulyoung could you make a spec that reproduces this issue for you?

@paulyoung
Copy link
Contributor Author

I wasn't sure where to start so just created a demo project that reproduces the issue for now.

@trustmaster
Copy link
Member

@paulyoung thanks! That should be sufficient!

@bergie
Copy link
Member

bergie commented Mar 1, 2017

Fixed via the Process API port of WirePattern #526

@bergie bergie closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants