Fixing GeoRSS namespace scoping and scoping use in specs #20

Merged
merged 3 commits into from Oct 31, 2012

Projects

None yet

2 participants

@tjdett
Contributor
tjdett commented Oct 30, 2012

The use of include GeoRuby; include GeoRuby::SimpleFeatures was
masking "include" issues in the GeoJSON and GeoRSS implementations.

By using those includes in global scope inside spec_helper.rb, they
altered the behaviour under lib/.

Sadly, simply using an include in the specs wasn't an option, due
to changes in Ruby 1.9.3: rspec/rspec-core#506

All the specs now use an absolute namespace for instantiating classes. GeoJSON and GeoRSS now explicitly include classes into their module scope.

The non-running KML tests have also been fixed and re-enabled.

tjdett added some commits Oct 30, 2012
@tjdett tjdett Combining not-running georss.rb tests with georss_spec.rb 1c91089
@tjdett tjdett Fixing KML tests. e1501e5
@tjdett tjdett Scoping class use in specs.
The use of "include GeoRuby; include GeoRuby::SimpleFeatures" was
masking "include" issues in the GeoJSON and GeoRSS implementations.

By using those includes in global scope inside `spec_helper.rb`, they
altered the behaviour under `lib/`.

Sadly, simply using an include in the specs wasn't an option either, due
to changes in Ruby 1.9.3:

rspec/rspec-core#506
71b9d6c
@nofxx nofxx merged commit 7b989f3 into nofxx:master Oct 31, 2012
@nofxx
Owner
nofxx commented Oct 31, 2012

Thanks man, great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment