ICE on previously working code (potentially due to nested arrays?)

[dkales]

Aim

Checkout https://github.com/TaceoLabs/noir-aes, a basic implementation of AES-128 and execute nargo test.
This worked fine with nargo v0.22.0, but has an ICE with v0.23.0.

Expected Behavior

Runs the tests and does not crash.

Bug

[aes] Testing test_aes_key_schedule... The application panicked (crashed).
Message:  internal error: entered unreachable code: ICE: Should have been in cache v80929 Instruction { instruction: Id(77801), position: 0, typ: Numeric(Unsigned { bit_size: 8 }) }
Location: compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs:1336

Under v0.24.0 there is a different error:

[aes] Testing test_aes_key_schedule... error: Internal Consistency Evaluators Errors:

                    This is likely a bug. Consider Opening an issue at https://github.com/noir-lang/noir/issues
  ┌─ /home/dkales/repos/noir_libs/noir-aes/src/lib.nr:1:1
  │
1 │ use dep::std;
  │ - ICE: Expected "a numeric value", found "[Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 })), Var(AcirVar(381), NumericType(Unsigned { bit_size: 8 }))]"

To Reproduce

1. git clone https://github.com/TaceoLabs/noir-aes && cd noir-aes
2. noirup -v v0.23.0 (or noirup -v v0.24.0)
3. nargo test
4. Observe ICE.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

The changelog of 0.23 talks about nested slices being banned, however the example just uses nested arrays, so I don;t know if this is related.

Installation Method

Binary (noirup default)

Nargo Version

nargo version = 0.23.0 noirc version = 0.23.0+5be9f9d7e2f39ca228df10e5a530474af0331704 (git version hash: 5be9f9d, is dirty: false)

NoirJS Version

--

Would you like to submit a PR for this Issue?

None

Support Needs

No response

[akonior]

I've got similar error trying to run nested arrays test:

#[test]
fn test_array_equal() {
    assert([[1]] == [[1]]);
}

Testing test_array_equal... error: Internal Consistency Evaluators Errors:

                    This is likely a bug. Consider opening an issue at https://github.com/noir-lang/noir/issues
  ┌─ /private/tmp/test_nest_array/src/main.nr:1:1
  │
1 │ fn main() {
  │ - ICE: Expected "a numeric value", found "[Var(AcirVar(1), NumericType(NativeField))]"
  │
  = Call stack:
    1. /private/tmp/test_nest_array/src/main.nr:6:12

[jfecher]

@akonior Thanks for the small example, it was very helpful in fixing the issue. I've made #4903 which should fix your issue and @dkales's issue as well.