Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Modifying generation script to correctly import and use the modules that export numbers. #8
I think I found a bug in the generation script for ES6 modules that affects the results in a real way.
This means that
On my local runs of the benchmark, this change more than doubles the amount of time that rollup takes overall. (Closure is smart enough to inline the vars, btw.)
Rollup is still faster than webpack, even with optimize-js patched for webpack bundles, but the comparison is a heckuva lot closer.
Thanks for all your work on this; you are great!
Don't be too hard on yourself; I myself have also made many, many similar mistakes in benchmarks. It's super easy to do.
Also, I want to say that it's so great that you posted the benchmark publicly so that this kind of review and double-checking can happen. And that I really appreciate your work, your Twitter feed, and your commitment to making the web better. Onwards!