New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify doc in localStorageTest() #6

Merged
merged 1 commit into from May 7, 2016

Conversation

Projects
None yet
2 participants
@duzun
Contributor

duzun commented May 7, 2016

localStorage can only store strings, thus the document is casted to a string automatically ([object Object]) and the test is not accurate, as other DB engines store the actual document.

Stringify doc in localStorageTest()
`localStorage` can only store strings, thus the document is casted to a string automatically (`[object Object]`) and the test is not accurate, as other DB engines store the actual document.
@nolanlawson

This comment has been minimized.

Show comment
Hide comment
@nolanlawson

nolanlawson May 7, 2016

Owner

Whoops, thank you for catching this! My bad.

Owner

nolanlawson commented May 7, 2016

Whoops, thank you for catching this! My bad.

@nolanlawson nolanlawson merged commit 01d9628 into nolanlawson:gh-pages May 7, 2016

@duzun

This comment has been minimized.

Show comment
Hide comment
@duzun

duzun May 7, 2016

Contributor

Now the test results are a little different for localStorage :-)

Cheers!

Contributor

duzun commented May 7, 2016

Now the test results are a little different for localStorage :-)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment