Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tappable and Clickable Space #163

Closed
ghost opened this issue Apr 18, 2018 · 5 comments · Fixed by #716
Closed

Tappable and Clickable Space #163

ghost opened this issue Apr 18, 2018 · 5 comments · Fixed by #716
Labels
accessibility Accessibility (a11y) enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Apr 18, 2018

Right now, it's entirely possible, especially on mobile layouts, to have absolutely no on-screen space where a user can tap the screen without causing an action. This can be an issue for people with hand tremors and similar issues (see https://axesslab.com/hand-tremors for an explanation).

I'd suggest an option to place extra spacing between posts, but I'm not sure that's a great fix, because it's entirely possible to have a post take up your entire screen. I'm not totally sure on this idea, but I think it'd be reasonable to make the space to the left of a post beneath avatars be unclickable? There's plenty of space to still click on the post and go to the full view, especially with the timestamp link also sending you there.

@nolanlawson
Copy link
Owner

Hmmmm that's interesting. What about an option to just disable "tap entire status to go to that status"? You can actually still go to the status by tapping on the date, so it technically doesn't lock the user out of any functionality.

That way, the only things that would be tappable are:

  • buttons
  • text links
  • image links

@nolanlawson nolanlawson added enhancement New feature or request accessibility Accessibility (a11y) labels Apr 19, 2018
@ghost
Copy link
Author

ghost commented Apr 20, 2018

That sounds like a pretty good plan!

@MarcoZehe
Copy link
Contributor

This would also be consistent with the reports screen reader users get from VoiceOver or other screen readers on various platforms, where only links (both text and image) and buttons are considered tapable. Well of course unless you count in the text areas for toots themselves. I never even tried to tap on the status text, always used the time stamp if I wanted to view the thread. Because the text was just text. ;)

@sorin-davidoi
Copy link
Contributor

The fact that the entire status is clickable also makes it impossible to select the content - as soon as the mouse click is released the page navigates to the status.

nolanlawson added a commit that referenced this issue Dec 3, 2018
fixes #163. also fixed the issue where selecting text would cause the toot to be tapped
nolanlawson added a commit that referenced this issue Dec 3, 2018
fixes #163. also fixed the issue where selecting text would cause the toot to be tapped
@nolanlawson
Copy link
Owner

I know this is an old issue, but for what it's worth the "I can't select text" issue has now been resolved regardless of whether the "Disable tappable area on entire toot" option is checked or not:

if (type === 'click') {
const selection = window.getSelection()
const selectionStr = selection && selection.toString()
if (selectionStr && selectionStr.length && target.contains(selection.anchorNode)) {
return // ignore if the user is selecting text inside the clickable area
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility (a11y) enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants