Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxError: Cannot declare a let variable twice: 'e' (inside of Fluid.app) #546

Closed
zachleat opened this issue Sep 14, 2018 · 3 comments · Fixed by #568
Closed

SyntaxError: Cannot declare a let variable twice: 'e' (inside of Fluid.app) #546

zachleat opened this issue Sep 14, 2018 · 3 comments · Fixed by #568
Labels
bug Something isn't working

Comments

@zachleat
Copy link

https://fluidapp.com/ runs Safari 11 (on my local machine) as an app wrapper for web sites. It throws a JS error when trying to add an instance on Pinafore.

image

image

Results in an inability to add an instance: the Log in button never grays out and hitting ENTER goes to a broken page

image

Consolation is that it works fine in Safari 11 standalone.

image

Dunno if this is worth fixing, but I’d love for Pinafore to work in Fluid.app

@nolanlawson
Copy link
Owner

Strange! It looks like some kind of minification error. I'll look into this.

@nolanlawson nolanlawson added the bug Something isn't working label Sep 23, 2018
@nolanlawson
Copy link
Owner

Looks like I just need to enable the safari10 setting in Uglify/Terser: mishoo/UglifyJS#1753

nolanlawson added a commit that referenced this issue Sep 23, 2018
nolanlawson added a commit that referenced this issue Sep 23, 2018
@zachleat
Copy link
Author

Awesome, thank you!

This might be a rats nest but I still wasn’t able to get it to work. Feel free to ignore this, I’ll just use my regular web browser to access Pinafore. Fluid.app must have some edge cases to it

image

(these errors appear on page load, not on the Add Instance workflow—although I am still not able to add an Instance)

Anyway, like I said—appreciate the help, probably not worth sinking more time into it ❤️

(Love Pinafore, thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants