Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert circle.svg for now to fix blank svg #1620

Closed
wants to merge 2 commits into from

Conversation

@nolanlawson
Copy link
Owner

nolanlawson commented Nov 1, 2019

fixes #1616

follow-up to #1618

@nolanlawson

This comment has been minimized.

Copy link
Owner Author

nolanlawson commented Nov 1, 2019

This just reverts the circle.svg back to the original version minus its width/height which aren't necessary since we have the viewbox.

Co-Authored-By: Cătălin Mariș <alrraa@gmail.com>
<svg viewBox="0 0 1792 1792" xmlns="http://www.w3.org/2000/svg"><path d="M1664 896q0 209-103 385.5t-279.5 279.5-385.5 103-385.5-103-279.5-279.5-103-385.5 103-385.5 279.5-279.5 385.5-103 385.5 103 279.5 279.5 103 385.5z" fill="#fff"/></svg>

This comment has been minimized.

Copy link
@alrra

alrra Nov 1, 2019

Contributor

Maybe the problem was that something expected a path and not a circle?

In any case, the path can be shorter:

Suggested change
<svg viewBox="0 0 1792 1792" xmlns="http://www.w3.org/2000/svg"><path d="M1664 896q0 209-103 385.5t-279.5 279.5-385.5 103-385.5-103-279.5-279.5-103-385.5 103-385.5 279.5-279.5 385.5-103 385.5 103 279.5 279.5 103 385.5z" fill="#fff"/></svg>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 17920 17920"><path fill="#fff" d="M16640 8960q0 2090-1030 3855t-2795 2795-3855 1030-3855-1030-2795-2795-1030-3855 1030-3855 2795-2795 3855-1030 3855 1030 2795 2795 1030 3855z"/></svg>

This comment has been minimized.

Copy link
@nolanlawson

nolanlawson Nov 1, 2019

Author Owner

Yeah that could be it. I think the build script assumes a path? In any case I saw the bug in both Firefox and Chrome, so I don't think it's a browser issue.

This comment has been minimized.

Copy link
@nolanlawson

nolanlawson Nov 1, 2019

Author Owner

You're right. OK that is a much simpler fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.