fix: fix autocomplete in voiceover+safari #1632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1629
Follow-up to #1630. I finally got Safari+VoiceOver working (mostly).
The trick was to not use an
aria-label
on therole="option"
element, and to instead just include a<span>
positioned offscreen (screen-reader-only class). Apparently Safari+VoiceOver doesn't see thearia-label
on theoption
.