New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate from CSV #75

Merged
merged 10 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@sidmani
Copy link
Collaborator

sidmani commented Jun 25, 2018

Rewrote all the scripts to create the databases from the pokeapi CSV files. Run npm get-csv and then run each file in bin/build-csv/build-*

  • The monsters.txt database is no longer necessary
  • Currently, the EV data is broken as it isn't present in the CSV files, but I can replace the JSON containing that data if you think that's an important stat to have

The scripts now generate all the data for Gen 6 and 7. The only things left are to update the CSS sprites and the monsterSummaries.json. (How are those generated?)

There are still some glitches that I need to fix, but I wanted to make the pull request to summarize the progress anyway.
To fix:

  • the background colors and types are flipped sometimes for dual-type Pokémon
  • Pokémon that don't evolve sometimes fail to load

@sidmani sidmani referenced this pull request Jun 25, 2018

Open

Updating build scripts #74

@nolanlawson

This comment has been minimized.

Copy link
Owner

nolanlawson commented Jun 28, 2018

@nolanlawson

This comment has been minimized.

Copy link
Owner

nolanlawson commented Jul 10, 2018

This looks fantastic. For the sprites, I manually downloaded them from some sprite sheet site (can't recall which one). For the summaries, I believe those are just a simple filter() operation on the monsters themselves, containing only the minimal data we need to render the home page (names, types, and IDs IIRC).

This PR looks great, still some work to do it seems but I'm happy to merge. You are also now a collaborator with full push rights, but feel free to open PRs and tag me for review. :)

I also still need to set up GitHub Pages so that we can deploy from the docs/ directory, and I also need to give you access to the public CouchDB database, but those are next on my todo list. Great work!!

@nolanlawson nolanlawson merged commit b2c0cd1 into master Jul 10, 2018

@sidmani sidmani deleted the generate-from-csv branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment