Permalink
Commits on Dec 8, 2010
  1. Fix line endings on UseFileOpenOnlyWithFileAccessRule

    Sebastien Pouliot authored and nolanlum committed Dec 6, 2010
  2. New UseFileOpenOnlyWithFileAccessRule for Gendarme's BadPractice rules

    Sebastien Pouliot authored and nolanlum committed Dec 5, 2010
    * Makefile.am: Add new rule / tests to the build.
    * UseFileOpenOnlyWithFileAccessRule.cs: New rule.
    * Test/UseFileOpenOnlyWithFileAccessTest.cs: New tests.
  3. Add two new rules from GCI to Gendarme's COM interop rules

    Sebastien Pouliot authored and nolanlum committed Dec 5, 2010
    * .gitignore: New. Ignore some generated files
    * Makefile.am: Add new rules and tests
    * AvoidInt64ArgumentsInComVisibleMethodsRule.cs: New rule.
    * ComVisibleShouldInheritFromComVisibleRule.cs: New rule.
    * Test/AvoidInt64ArgumentsInComVisibleMethodsTest.cs: New tests.
    * Test/ComVisibleShouldInheritFromComVisibleTest.cs: New tests.
  4. Update Gendarme's authors list and self-test ignore entries (wrt new …

    Sebastien Pouliot authored and nolanlum committed Dec 3, 2010
    …rules)
  5. Fix EnsureLocalDisposalRule wrt IDisposable objects not stored at all

    Sebastien Pouliot authored and nolanlum committed Dec 3, 2010
    * rules/Gendarme.Rules.Correctness/EnsureLocalDisposalRule.cs: Report
    defects when the IDisposable object is not stored at all. Fix bug #651493
    * rules/Gendarme.Rules.Correctness/Test/EnsureLocalDisposalTest.cs:
    Additional tests
    
    * console/HtmlResultWriter.cs:
    * rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs:
    * swf-wizard-runner/Gendarme.cs:
    * swf-wizard-runner/Wizard.cs:
    	Fix new (self-test) defects found by the rule enhancements
    
    Patches from Antoine Vandecreme
  6. Add AutoLayoutTypesShouldNotBeComVisibleRule|Test from GCI

    Sebastien Pouliot authored and nolanlum committed Dec 3, 2010
    * Makefile.am: Add rule/tests to the build
    * AutoLayoutTypesShouldNotBeComVisibleRule.cs: New rule.
    * Test/AutoLayoutTypesShouldNotBeComVisibleTest.cs: New tests.
  7. Fix NRE in Gendarme's ReviewLinqMethodRule - bug #656790

    Sebastien Pouliot authored and nolanlum committed Dec 1, 2010
    * ReviewLinqMethodRule.cs: Fix Resolve call on a (possibly) null
    value (easy since the Resolve was not required). Fix bug #656790.
    
    * Test/ReviewLinqMethodTest.cs: Add unit test beased on the code
    provided in the original bug report by David Schmitt
  8. Fix self-test defects on RemoveDependenceOnObsoleteCodeRule wrt cecil…

    Sebastien Pouliot authored and nolanlum committed Nov 28, 2010
    …/light
    
    * RemoveDependenceOnObsoleteCodeRule.cs: Fix several AvoidRepetitiveCalls
    ToPropertiesRule defects that occurs with the newer cecil (properties are
    larger than they were previously).
  9. New tool to generate mappings between Gendarme and FxCop (GCI)

    Sebastien Pouliot authored and nolanlum committed Dec 1, 2010
    * FxCopMapBuilder.cs: New. Unsupported tool to generate doc
    * FxCopRule.cs: New.
    * README: Documentation
    
    Author: Yuri Stuken
  10. Add new ComVisibleTypesShouldBeCreatable[Rule|Test].cs from GCI

    Sebastien Pouliot authored and nolanlum committed Dec 1, 2010
    * Makefile.am: Add both rule and tests to the build
    * ComVisibleTypesShouldBeCreatableRule.cs: New rule.
    * Test/ComVisibleTypesShouldBeCreatableTest.cs: New unit tests
    
    author: Nicholas Rioux
Commits on Dec 6, 2010
  1. Update csproj files with new rules

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 6, 2010
  2. Fix line endings on UseFileOpenOnlyWithFileAccessRule

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 6, 2010
Commits on Dec 5, 2010
  1. New UseFileOpenOnlyWithFileAccessRule for Gendarme's BadPractice rules

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 5, 2010
    * Makefile.am: Add new rule / tests to the build.
    * UseFileOpenOnlyWithFileAccessRule.cs: New rule.
    * Test/UseFileOpenOnlyWithFileAccessTest.cs: New tests.
  2. Add two new rules from GCI to Gendarme's COM interop rules

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 5, 2010
    * .gitignore: New. Ignore some generated files
    * Makefile.am: Add new rules and tests
    * AvoidInt64ArgumentsInComVisibleMethodsRule.cs: New rule.
    * ComVisibleShouldInheritFromComVisibleRule.cs: New rule.
    * Test/AvoidInt64ArgumentsInComVisibleMethodsTest.cs: New tests.
    * Test/ComVisibleShouldInheritFromComVisibleTest.cs: New tests.
Commits on Dec 3, 2010
  1. Update Gendarme's authors list and self-test ignore entries (wrt new …

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 3, 2010
    …rules)
  2. Add PreferInterfaceConstraintOnGenericParameterForPrimitiveInterfaceR…

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 3, 2010
    …ule|Test to gendarme
    
    * Makefile.am: Add new rule / tests to build.
    
    * PreferInterfaceConstraintOnGenericParameterForPrimitiveInterfaceRule.cs: New rule
    * Test/PreferInterfaceConstraintOnGenericParameterForPrimitiveInterfaceTest.cs: New tests
  3. Fix EnsureLocalDisposalRule wrt IDisposable objects not stored at all

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 3, 2010
    * rules/Gendarme.Rules.Correctness/EnsureLocalDisposalRule.cs: Report
    defects when the IDisposable object is not stored at all. Fix bug #651493
    * rules/Gendarme.Rules.Correctness/Test/EnsureLocalDisposalTest.cs:
    Additional tests
    
    * console/HtmlResultWriter.cs:
    * rules/Gendarme.Rules.Portability/MonoCompatibilityReviewRule.cs:
    * swf-wizard-runner/Gendarme.cs:
    * swf-wizard-runner/Wizard.cs:
    	Fix new (self-test) defects found by the rule enhancements
    
    Patches from Antoine Vandecreme
  4. Add AutoLayoutTypesShouldNotBeComVisibleRule|Test from GCI

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 3, 2010
    * Makefile.am: Add rule/tests to the build
    * AutoLayoutTypesShouldNotBeComVisibleRule.cs: New rule.
    * Test/AutoLayoutTypesShouldNotBeComVisibleTest.cs: New tests.
Commits on Dec 1, 2010
  1. Fix NRE in Gendarme's ReviewLinqMethodRule - bug #656790

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 1, 2010
    * ReviewLinqMethodRule.cs: Fix Resolve call on a (possibly) null
    value (easy since the Resolve was not required). Fix bug #656790.
    
    * Test/ReviewLinqMethodTest.cs: Add unit test beased on the code
    provided in the original bug report by David Schmitt
  2. Fix self-test defects on RemoveDependenceOnObsoleteCodeRule wrt cecil…

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 28, 2010
    …/light
    
    * RemoveDependenceOnObsoleteCodeRule.cs: Fix several AvoidRepetitiveCalls
    ToPropertiesRule defects that occurs with the newer cecil (properties are
    larger than they were previously).
  3. Add new AvoidUnnecessaryOverridesRule performance rule

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 1, 2010
    * Makefile.am: Add new rule / tests to the build.
    * AvoidUnnecessaryOverridesRule.cs: New rule.
    * Test/AvoidUnnecessaryOverridesTest.cs: New tests.
    
    Author: N Lum
  4. New tool to generate mappings between Gendarme and FxCop (GCI)

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 1, 2010
    * FxCopMapBuilder.cs: New. Unsupported tool to generate doc
    * FxCopRule.cs: New.
    * README: Documentation
    
    Author: Yuri Stuken
  5. Feedback, round 2.

    nolanlum committed Dec 1, 2010
    Fix redundancy in an if. Correctly exploit short-circuit evaluation.
  6. Add new ComVisibleTypesShouldBeCreatable[Rule|Test].cs from GCI

    Sebastien Pouliot
    Sebastien Pouliot committed Dec 1, 2010
    * Makefile.am: Add both rule and tests to the build
    * ComVisibleTypesShouldBeCreatableRule.cs: New rule.
    * Test/ComVisibleTypesShouldBeCreatableTest.cs: New unit tests
    
    author: Nicholas Rioux
Commits on Nov 29, 2010
  1. Add new performance rule. (GCI)

    nolanlum committed Nov 29, 2010
    * Makefile.am: Integrate into build.
    
    * AvoidUnnecessaryOverridesRule.cs:
    * Test/AvoidUnnecessaryOverridesTest.cs:
        Rule and unit tests to avoid overrides that do nothing but call the base class.
  2. Forgot to commit this - fix mono-tools build.

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 29, 2010
    * framework/Gendarme.Framework.Rocks/ParameterRocks.cs: Apply
    AvoidUnnecessarySpecializationRule on GetSequence
Commits on Nov 28, 2010
  1. Fix some AvoidUnnecessarySpecializationRule on gendarme after cecil/l…

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 28, 2010
    …ight merge
    
    * framework/Gendarme.Framework.Engines/SuppressMessageEngine.cs:
    * rules/Gendarme.Rules.Design/ConsiderAddingInterfaceRule.cs:
    * rules/Gendarme.Rules.Maintainability/AvoidUnnecessarySpecializationRule.cs:
    * rules/Gendarme.Rules.Smells/AvoidLongParameterListsRule.cs:
    * rules/Gendarme.Rules.Smells/CodeDuplicatedLocator.cs:
    * rules/Gendarme.Rules.Smells/InstructionMatcher.cs:
    	Changes in the new Cecil API makes it possible to use a base
    	class in several methods parameters. Reduce self-test defects
  2. Fix some self-test default related to the update to cecil/light

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 28, 2010
    * CecilRocks.cs: Remove the GetAssembly(TypeReference) method since, with
    cecil.light, the method GetAssembly(MemberReference) provides the same
    * CustomAttributeRocks.cs: Apply AvoidUnnecessarySpecializationRule on
    Contains[Any]Type rock which has the added bonus to remove the dependency
    on cecil's collections.
    * ModuleRocks.cs: Fix CheckParametersNullityInVisibleMethodsRule in a few
    rocks.
  3. Windows-build changes for new assembly / rules

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 28, 2010
    * rules/Gendarme.Rules.Interoperability.Com/Gendarme.Rules.Interoperability.Com.csproj:
    Add new rule
    
    * rules/Gendarme.Rules.Interoperability.Com/Test/Tests.Rules.Interoperability.Com.csproj:
    Add new unit test
    
    * rules/Gendarme.Rules.Smells/Test/Tests.Rules.Smells.csproj: Move
    destination assembly so Mono.Cecil.Pdb.dll is available (and avoid
    ignoring some test cases).
    
    * wix/Product.wxs: Add Gendarme.Rules.Interoperability.Com to the
    win32 installer
  4. Apply/ignore AvoidUnnecessarySpecializationRule on TypeRocks after ce…

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 28, 2010
    …cil/light merge
    
    * self-test.ignore: Ignore some cases of AvoidUnnecessarySpecializationRule
    in TypeRocks where the context (type) is more important than the rule
    
    * framework/Gendarme.Framework.Rocks/TypeRocks.cs: Apply AvoidUnnecessary
    SpecializationRule on Contains[Any]Type rock which has the added bonus to
    remove the dependency on cecil's collections. Fix CheckParametersNullity
    InVisibleMethodsRule in GetMethod rock.
Commits on Nov 27, 2010
  1. New AvoidOverloadsInComVisibleInterfacesRule from Google Code In

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 27, 2010
    * Makefile.am: Add new files to the build
    
    * AvoidNonPublicFieldsInComVisibleValueTypesRule.cs: Now use ComRocks
    * AvoidOverloadsInComVisibleInterfacesRule.cs: New rule.
    * ComRocks.cs: New. Extensions method to detect ComVisible
    
    * Test/AvoidOverloadsInComVisibleInterfacesTest.cs: New unit tests.
    * Test/ComRocksTest.cs: New unit tests.
    
    author: N Lum
  2. Include Interoperability.Com in self-test (but not in default) rule set

    Sebastien Pouliot
    Sebastien Pouliot committed Nov 27, 2010
    * rules/rules.xml: Include rules from Gendarme.Rules.Interoperability.Com
    in self-test, but not in default, rule set. Also create a specific
    "interop-com" rule set containing only the COM rules.